-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-47535: use pf v5 variables and table component #307
OCPBUGS-47535: use pf v5 variables and table component #307
Conversation
@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jgbernalp This PR is going to run into some conflicts with both #306 and #304. We should decide which order we want to merge the items in (I believe this PR can come first) and then rebase the others PR's on top of that one. Not really relevant, but this situation would be a lovely place for using something like PR stacking |
/retest |
/hold until we cut the release branch for COO as this will support older OCP versions |
/lgtm |
ddff3a5
to
c737075
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
/retest-required |
@jgbernalp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
tested with PR, issue is fixed, see bug comment |
@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/unhold |
@jgbernalp: Jira Issue OCPBUGS-47535: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-47535 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: monitoring-plugin |
This PR:
Smoke tested with openshift/console#14615