Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-47535: use pf v5 variables and table component #307

Merged

Conversation

jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Jan 2, 2025

This PR:

  • Replaces all usages of patternfly variables and classes of V4 with V5
  • Updates the patternfly table from V4 to V5
  • Upgrades patternfly react table and charts packages

Smoke tested with openshift/console#14615

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 2, 2025
@openshift-ci-robot
Copy link

@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR:

  • Replaces all usages of patternfly V4 with V5
  • Updates the patternfly table from V4 to V5
  • Upgrades patternfly react table and charts packages

Smoke tested with openshift/console#14615

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 2, 2025
@openshift-ci openshift-ci bot requested review from PeterYurkovich and zhuje January 2, 2025 13:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
@jgbernalp
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 2, 2025
@openshift-ci-robot
Copy link

@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

This PR:

  • Replaces all usages of patternfly variables and classes of V4 with V5
  • Updates the patternfly table from V4 to V5
  • Upgrades patternfly react table and charts packages

Smoke tested with openshift/console#14615

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from juzhao January 2, 2025 13:07
@openshift-ci-robot
Copy link

@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
Copy link
Contributor

@jgbernalp This PR is going to run into some conflicts with both #306 and #304. We should decide which order we want to merge the items in (I believe this PR can come first) and then rebase the others PR's on top of that one.

Not really relevant, but this situation would be a lovely place for using something like PR stacking

@jgbernalp
Copy link
Contributor Author

/retest

@jgbernalp
Copy link
Contributor Author

/hold until we cut the release branch for COO as this will support older OCP versions

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2025
@jgbernalp jgbernalp force-pushed the update-to-patternfly-5 branch from ddff3a5 to c737075 Compare January 13, 2025 08:12
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@jgbernalp
Copy link
Contributor Author

/retest

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor Author

/retest

@PeterYurkovich
Copy link
Contributor

/retest

@juzhao
Copy link

juzhao commented Jan 14, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@juzhao
Copy link

juzhao commented Jan 14, 2025

tested with PR, issue is fixed, see bug comment
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 14, 2025
@openshift-ci-robot
Copy link

@jgbernalp: This pull request references Jira Issue OCPBUGS-47535, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

This PR:

  • Replaces all usages of patternfly variables and classes of V4 with V5
  • Updates the patternfly table from V4 to V5
  • Upgrades patternfly react table and charts packages

Smoke tested with openshift/console#14615

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit adb74bd into openshift:main Jan 14, 2025
7 checks passed
@openshift-ci-robot
Copy link

@jgbernalp: Jira Issue OCPBUGS-47535: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47535 has been moved to the MODIFIED state.

In response to this:

This PR:

  • Replaces all usages of patternfly variables and classes of V4 with V5
  • Updates the patternfly table from V4 to V5
  • Upgrades patternfly react table and charts packages

Smoke tested with openshift/console#14615

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: monitoring-plugin
This PR has been included in build monitoring-plugin-container-v4.19.0-202501141108.p0.gadb74bd.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants