-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master #1048
base: main
Are you sure you want to change the base?
Conversation
…Rs with delay - Changed the logic in the sriov-network-operator controller to handle stale SriovNetworkNodeState CRs (those with no matching Nodes with daemon). - Introduced a delay (30 minutes by default) before removing stale state CRs to manage scenarios where the user temporarily removes the daemon from the node but does not want to lose the state stored in the SriovNetworkNodeState. - Added the `STALE_NODE_STATE_CLEANUP_DELAY_MINUTES` environment variable to configure the required delay in minutes (default is 30 minutes).
if we run on a system where the PF is not connected to the network we can still use it for tests but we need the link state to not be auto. Signed-off-by: Sebastian Sch <[email protected]>
This will fix the issue we sometime see ` <string>: Dump was interrupted and may be inconsistent.\n` https://docs.kernel.org/userspace-api/netlink/intro.html#dump-consistency Signed-off-by: Sebastian Sch <[email protected]>
functest: Fix ip link command output
add link state enable on test
It's enouph to configure ib_core module in /etc/moprobe.d/ for Ubuntu OS to change RDMA subsystem mode. Also this commit add OS check into kargs.sh error because 'grubby' isn't available in official Ubuntu repositories. Kernel param configuration support in Ubuntu should be implemented in a separate commit. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
b36e28a
to
46a3625
Compare
Signed-off-by: Sebastian Sch <[email protected]>
…-state feat: Update controller logic to handle stale SriovNetworkNodeState CRs with delay
46a3625
to
aee8e41
Compare
Skip kernel parameters configuration for Ubuntu
Bump k8s version ci
aee8e41
to
a7f2cdb
Compare
/test e2e-telco5g-sriov |
1 similar comment
/test e2e-telco5g-sriov |
0383066
to
c66a5dd
Compare
/test e2e-telco5g-sriov |
5cf94e0
to
c755843
Compare
with the introduction of rdma system mode change on baremetal systems it takes more than 1h that is the default for ginkgo Signed-off-by: Sebastian Sch <[email protected]>
/test e2e-telco5g-sriov |
@SchSeba: No presubmit jobs available for openshift/sriov-network-operator@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
extend func-test timeout
c755843
to
267d145
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@SchSeba: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-telco5g-sriov |
/retest |
1 similar comment
/retest |
Hi @zeeke, |
@SchSeba: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.