Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into master #1048

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Dec 30, 2024

No description provided.

ykulazhenkov and others added 4 commits December 2, 2024 17:31
…Rs with delay

- Changed the logic in the sriov-network-operator controller to handle stale SriovNetworkNodeState CRs (those with no matching Nodes with daemon).
- Introduced a delay (30 minutes by default) before removing stale state CRs to manage scenarios where the user temporarily removes the daemon from the node but does not want to lose the state stored in the SriovNetworkNodeState.
- Added the `STALE_NODE_STATE_CLEANUP_DELAY_MINUTES` environment variable to configure the required delay in minutes (default is 30 minutes).
if we run on a system where the PF is not connected to the network
we can still use it for tests but we need the link state to not be
auto.

Signed-off-by: Sebastian Sch <[email protected]>
This will fix the issue we sometime see ` <string>: Dump was interrupted and may be
inconsistent.\n`

https://docs.kernel.org/userspace-api/netlink/intro.html#dump-consistency

Signed-off-by: Sebastian Sch <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
SchSeba and others added 2 commits December 31, 2024 11:34
It's enouph to configure ib_core module in /etc/moprobe.d/ for
Ubuntu OS to change RDMA subsystem mode.

Also this commit add OS check into  kargs.sh error because 'grubby'
isn't available in official Ubuntu repositories.

Kernel param configuration support in Ubuntu should be implemented
in a separate commit.

Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
…-state

feat: Update controller logic to handle stale SriovNetworkNodeState CRs with delay
SchSeba and others added 2 commits January 2, 2025 15:32
@zeeke
Copy link
Contributor

zeeke commented Jan 3, 2025

/test e2e-telco5g-sriov

1 similar comment
@zeeke
Copy link
Contributor

zeeke commented Jan 3, 2025

/test e2e-telco5g-sriov

@SchSeba SchSeba force-pushed the merge-bot-master branch 4 times, most recently from 0383066 to c66a5dd Compare January 6, 2025 23:48
@zeeke
Copy link
Contributor

zeeke commented Jan 7, 2025

/test e2e-telco5g-sriov

@SchSeba SchSeba force-pushed the merge-bot-master branch 2 times, most recently from 5cf94e0 to c755843 Compare January 8, 2025 23:49
with the introduction of rdma system mode change on baremetal
systems it takes more than 1h that is the default for ginkgo

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba
Copy link
Contributor Author

SchSeba commented Jan 9, 2025

/test e2e-telco5g-sriov

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

@SchSeba: No presubmit jobs available for openshift/sriov-network-operator@main

In response to this:

/test e2e-telco5g-sriov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jan 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SchSeba
Copy link
Contributor Author

SchSeba commented Jan 12, 2025

/test ?

Copy link
Contributor

openshift-ci bot commented Jan 12, 2025

@SchSeba: The following commands are available to trigger required jobs:

/test api
/test ci-index-operator-bundle
/test controllers
/test gofmt
/test images
/test operator-e2e
/test pkg

The following commands are available to trigger optional jobs:

/test e2e-openstack-nfv
/test e2e-openstack-nfv-config-drive
/test e2e-telco5g-sriov
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-sriov-network-operator-main-api
pull-ci-openshift-sriov-network-operator-main-ci-index-operator-bundle
pull-ci-openshift-sriov-network-operator-main-controllers
pull-ci-openshift-sriov-network-operator-main-e2e-openstack-nfv
pull-ci-openshift-sriov-network-operator-main-e2e-openstack-nfv-config-drive
pull-ci-openshift-sriov-network-operator-main-gofmt
pull-ci-openshift-sriov-network-operator-main-images
pull-ci-openshift-sriov-network-operator-main-operator-e2e
pull-ci-openshift-sriov-network-operator-main-pkg
pull-ci-openshift-sriov-network-operator-main-security

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SchSeba
Copy link
Contributor Author

SchSeba commented Jan 12, 2025

/test e2e-telco5g-sriov

@SchSeba
Copy link
Contributor Author

SchSeba commented Jan 12, 2025

/retest

1 similar comment
@SchSeba
Copy link
Contributor Author

SchSeba commented Jan 12, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Jan 12, 2025

@SchSeba: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-config-drive 267d145 link false /test e2e-openstack-nfv-config-drive
ci/prow/e2e-openstack-nfv 267d145 link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants