Add some more functionality and checks to the restart/upgrade test #3431
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
scenarios/examples/util.py
Outdated
| @@ -301,7 +301,7 @@ async def anoncreds_issue_credential_v2( | |||
| ) | |||
| holder_indy_record = await holder.event_with_values( | |||
| topic="issue_credential_v2_0_anoncreds" | |||
| if is_holder_anoncreds | |||
| if (is_holder_anoncreds or is_issuer_anoncreds) | |||
There was a problem hiding this comment.
This change in util.py allows the event issue_credential_v2_0_anoncreds from an askar holder (this is what I observed in the test, and also in the alice/faber demo).
There was a problem hiding this comment.
Tests look great. I do remember this and wasn't exactly sure what to do. I'll need to think about it for a bit.
Signed-off-by: Ian Costanzo <[email protected]>
|
There was a problem hiding this comment.
Looks good! I'm glad this is tested more thoroughly. I meant to do this for a long time.
For the changing of the event name, this already requires both parties being on the latest version of acapy, so I think adding the anoncreds event handler to an indy agent for forward compatibility would solve the issue.
That's not an issue that needs to be addressed in this PR. I'll create a separate issue for it.
Fleshes out the upgrade & restart scenario test (checks record counts, issues and revokes credentials after restart, etc).
There is one event type I'm not sure of (issue credential from anoncreds issuer agent to askar holder agent and one of the holder events is
_anoncredsrather than_indy. I patched the test to allow this?