Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Updated version switcher and offline docs URLs #210

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Oct 23, 2024

  • Fixed repeated versions in version map on consecutive builds.
  • Fixed double logo on narrow screen.

- Fixed repeated versions in version map on consecutive builds.
- Fixed double logo on narrow screen.
@pandafy pandafy force-pushed the fix-version-switcher branch from 6034158 to b2b18a3 Compare October 23, 2024 17:06
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some adjustments to the CSS.

I found a problem during testing. I tried adding another version in the switcher but it's not shown, only one dropdown is shown. Please make sure multiple options are supported.

conf.py Outdated Show resolved Hide resolved
@pandafy
Copy link
Member Author

pandafy commented Oct 24, 2024

I found a problem during testing. I tried adding another version in the switcher but it's not shown, only one dropdown is shown. Please make sure multiple options are supported.

Screenshot from 2024-10-24 15-47-15

It worked for me.

The version switcher is disabled on page which does not exist on other version. E.g. the "Modules" pages is only present in the "dev" version.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nemesifier nemesifier merged commit 519da77 into master Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants