Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added support for password expiration feature #713 #724

Merged
merged 8 commits into from
Nov 15, 2023

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Nov 6, 2023

@pandafy pandafy force-pushed the issues/713-password-expiration branch from 298e847 to cecc6c4 Compare November 6, 2023 19:33
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see my comment below.

i18n/en.po Outdated
@@ -517,6 +517,10 @@ msgstr "Login successful"
msgid "LOGOUT_SUCCESS"
msgstr "Logout successful"

#: client/components/status/status.js:119
msgid "PASSWORD_EXPIRED"
msgstr "Your password has expired, please change your password."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Your password has expired, please change your password."
msgstr "Your password has expired, please update it."

Please port the changes to the other languages using google translate.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready, waiting for the PRs depended upon to be merged.

@nemesifier nemesifier merged commit 4507596 into master Nov 15, 2023
1 of 2 checks passed
@nemesifier nemesifier deleted the issues/713-password-expiration branch November 15, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add support for password expiration feature
2 participants