-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Twitter logo. #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @d1vyanshu-kumar 👍 !
I think we should change also the text "Login with Twitter" to "Login with X".
The commit message does not follow our commit message conventions,
please change it to "[change] Updated X logo".
We shouldn't use "[fix]" here because this is not a bug fix.
I don't see this blue X logo on https://about.twitter.com/en/who-we-are/brand-toolkit. Where did you download this from @d1vyanshu-kumar ? |
@pandafy |
is there any command to generate config.yml.hbs so that I can reflect the change on the main server or website? |
@d1vyanshu-kumar I think you will need to tweak CSS which is changing the colour of the logo. The new logo is black and white. |
@d1vyanshu-kumar the QA checks and tests are failing. Can you fix them? |
17956b5
to
62b616e
Compare
Closes #743
After Modification: