Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Twitter logo. #746

Closed

Conversation

d1vyanshu-kumar
Copy link
Contributor

@d1vyanshu-kumar d1vyanshu-kumar commented Jan 24, 2024

Closes #743
After Modification:
Screenshot 2024-01-24 at 9 34 20 PM

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @d1vyanshu-kumar 👍 !

I think we should change also the text "Login with Twitter" to "Login with X".

The commit message does not follow our commit message conventions,
please change it to "[change] Updated X logo".
We shouldn't use "[fix]" here because this is not a bug fix.

@pandafy
Copy link
Member

pandafy commented Jan 25, 2024

I don't see this blue X logo on https://about.twitter.com/en/who-we-are/brand-toolkit. Where did you download this from @d1vyanshu-kumar ?

@d1vyanshu-kumar
Copy link
Contributor Author

d1vyanshu-kumar commented Jan 25, 2024

@pandafy
I found this logo from this website:
https://tishonator.com/blog/upgrading-to-the-latest-twitter-logo-on-your-website
The logo is blue because of the fill="#1da1f2" attribute in the element. This sets the colour of the logo to the official Twitter blue.

@d1vyanshu-kumar
Copy link
Contributor Author

Thank you for this PR @d1vyanshu-kumar 👍 !

I think we should change also the text "Login with Twitter" to "Login with X".

The commit message does not follow our commit message conventions, please change it to "[change] Updated X logo". We shouldn't use "[fix]" here because this is not a bug fix.

is there any command to generate config.yml.hbs so that I can reflect the change on the main server or website?

@d1vyanshu-kumar d1vyanshu-kumar changed the title Fix Twitter Logo Bug Improve Twitter logo. Jan 27, 2024
@pandafy
Copy link
Member

pandafy commented Jan 29, 2024

@pandafy I found this logo from this website: https://tishonator.com/blog/upgrading-to-the-latest-twitter-logo-on-your-website The logo is blue because of the fill="#1da1f2" attribute in the element. This sets the colour of the logo to the official Twitter blue.

@d1vyanshu-kumar I think you will need to tweak CSS which is changing the colour of the logo. The new logo is black and white.

@d1vyanshu-kumar
Copy link
Contributor Author

Screenshot 2024-02-02 at 7 46 09 PM

–> I have changed the logo and the text from “login with Twitter” to “login with X”. Please review it and give me your feedback.

@pandafy
Copy link
Member

pandafy commented Feb 9, 2024

@d1vyanshu-kumar the QA checks and tests are failing. Can you fix them?

@d1vyanshu-kumar d1vyanshu-kumar deleted the twitter_logo_fix branch February 10, 2024 06:28
@d1vyanshu-kumar d1vyanshu-kumar restored the twitter_logo_fix branch February 10, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change] Outdated Twitter Logo
3 participants