[minor]: enumeration macros - #31
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces three new Swift macros: @ambient, @Discriminated, and @Projection, along with their implementations and comprehensive unit tests. The reviewer provided valuable feedback to make these macros more robust. Key recommendations include: safely handling enum modifiers (such as filtering out indirect and conditionally applying @inlinable based on access control), supporting non-optional associated values in @Projection by checking if the parameter type is syntactically optional, and improving optional flattening in @Projection to correctly detect unsugared optionals like Optional<T>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because
@ambientis languagey.@Discriminatedand@Projectionare not languagey, i just made them up myself.