Fix/reapply fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaltzforvenus
force-pushed
the
fix/reapply-fixes
branch
from
d95a527 to
646b6be
Compare
lj-dickey
reviewed
Jul 31, 2024
| .appendingPathComponent("\(testName).\(identifier)") | ||
| .appendingPathExtension(snapshotting.pathExtension ?? "") | ||
|
|
||
| // Check the bundle for the resource first, then the file system |
There was a problem hiding this comment.
Could you clean up the indenting of the code?
lj-dickey
requested changes
Jul 31, 2024
lj-dickey
reviewed
Jul 31, 2024
| // But, if we're recording, don't bother checking the bundle, since we aren't comparing it to anything, and | ||
| // want the new file to be generated in the source directory, not the bundle. | ||
| var snapshotFileUrlCandidate: URL? | ||
| if record != .never { |
There was a problem hiding this comment.
Wouldn't we want to check the bundle if the recording is never or missing? Because we'd need to know if the snapshot existed before deciding whether to record... So, this comparison seems incorrect - should it be record != .always? Then, if the file isn't found in the bundle, create it in the snapshot directory.
There was a problem hiding this comment.
Yeah, good call. Will change.
|
Testing this locally before I call it good for another look. |
|
Alright, I did run the puffin repo against this branch, and things are working as I expect them to, so I think this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.