forked from liftoff-app/liftoff
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liftoff app master #2
Open
orl0pl
wants to merge
26
commits into
master
Choose a base branch
from
liftoff-app-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was converting blank fields to null, which is interpreted upstream as "no change needed" Co-authored-by: @mykdavies <[email protected]>
Addresses a `TODO` comment I left in liftoff-app#424. Also improves performance (probably because there's now less renders.
Fixes regression caused in liftoff-app#441
…iftoff-app#442) IMHO it looks much better. (I kind of stole the new background color from a preview screenshot of Sync for Lemmy). This also renames the options for rounding/shadow so that it resets existing user settings. That way, people have to see the new look, dislike it and _actively choose_ to go back to the old look. ![Screenshot_20230723-005955.png](https://github.com/liftoff-app/liftoff/assets/856493/b9282522-811b-4e63-b995-7aaf8923f85d) ![Screenshot_20230723-005922.png](https://github.com/liftoff-app/liftoff/assets/856493/28149a48-7291-4406-9ed6-631f929bd220)
Might lead to requests to pause other sources on unmute, but let's solve one problem at a time. Co-authored-by: @mykdavies <[email protected]>
A couple of small changes to the documentation. Co-authored-by: @mykdavies <[email protected]> Co-authored-by: Lasath Fernando <[email protected]>
Really simple implementation to make it available and find out how people *really* want to use it. Read the comment for possible issues. --------- Co-authored-by: @mykdavies <[email protected]>
Avoids the system area using the wrong colours after MediaView closes. Co-authored-by: @mykdavies <[email protected]>
Splitscreen support, plus a small fix to the .gitignore and a correction to the App Store button size in the README. Co-authored-by: @mykdavies <[email protected]>
…liftoff-app-master
…into liftoff-app-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.