Add image-builder-frontend specfile (HMS-5221)

[kingsleyzissou]

This PR adds the initial specfile to the project and convenience scripts in the Makefile to build rpms and srpms

/jira-epic COMPOSER-2411

JIRA: HMS-5221

[kingsleyzissou]

This depends on #2603

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (29736d8) to head (aa43e58).

@@           Coverage Diff           @@
##             main    #2701   +/-   ##
=======================================
  Coverage   84.86%   84.86%           
=======================================
  Files         183      183           
  Lines       20783    20783           
  Branches     2018     2018           
=======================================
  Hits        17638    17638           
  Misses       3123     3123           
  Partials       22       22           

Files with missing lines	Coverage Δ
src/constants.ts	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29736d8...aa43e58. Read the comment docs.

[croissanne]

Nice! A few comments, also we could add a packit config to start building rpms:

upstream_project_url: https://github.com/osbuild/image-builder-frontend
specfile_path: cockpit/image-builder-frontend.spec
upstream_package_name: cockpit-composer
downstream_package_name: cockpit-composer
# use the nicely formatted release description from our upstream release, instead of git shortlog
copy_upstream_release_description: true

actions:
  create-archive: make dist

srpm_build_deps:
  - make
  - npm

jobs:
  - job: copr_build
    trigger: pull_request
    targets: &build_targets
      - centos-stream-9
      - centos-stream-10
      - fedora-all

[kingsleyzissou]

/retest

[croissanne]

/packit build

[packit-as-a-service]

No config file for packit (e.g. .packit.yaml) found in osbuild/image-builder-frontend on commit 5fc7289

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[kingsleyzissou]

Ah right, I put it in the cockpit dir. I'll move it to the top level

[thozza]

On a general note, wouldn't it make more sense to ship this as image-builder-frontend or cockpit-image-builder RPM? Sure, a bit more work to add a new package to Fedora, but it would look much cleaner to me. The new RPM can then Obsolete cockpit-composer, so the upgrade path would be preserved. 🤔

[packit-as-a-service]

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'cockpit-composer': {'value': {'actions': ["Unknown action(s) provided: ['install']"]}}})}}, 'packages': defaultdict(<class 'dict'>, {'cockpit-composer': {'value': {'actions': ["Unknown action(s) provided: ['install']"]}}})})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[packit-as-a-service]

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'cockpit-composer': {'value': {'actions': ["Unknown action(s) provided: ['install']"]}}})}}, 'packages': defaultdict(<class 'dict'>, {'cockpit-composer': {'value': {'actions': ["Unknown action(s) provided: ['install']"]}}})})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[packit-as-a-service]

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'cockpit-composer': {'value': {'actions': ["Unknown action(s) provided: ['install']"]}}})}}, 'packages': defaultdict(<class 'dict'>, {'cockpit-composer': {'value': {'actions': ["Unknown action(s) provided: ['install']"]}}})})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

[lucasgarfield]

On a general note, wouldn't it make more sense to ship this as image-builder-frontend or cockpit-image-builder RPM? Sure, a bit more work to add a new package to Fedora, but it would look much cleaner to me. The new RPM can then Obsolete cockpit-composer, so the upgrade path would be preserved. 🤔

This makes good sense to me. I'm not sure that either myself or @kingsleyzissou have enough experience packing in Fedora to make this happen in a reasonable amount of time... we'd need to rely on your help pretty heavily @thozza, would you mind helping us get this into Rawhide?

[ondrejbudai]

It somewhat depends on the timeframe. If we want to ship it in RHEL 10.0, the cockpit-composer shortcut (while being ugly) might be the only way.

[supakeen]

On a general note, wouldn't it make more sense to ship this as image-builder-frontend or cockpit-image-builder RPM? Sure, a bit more work to add a new package to Fedora, but it would look much cleaner to me. The new RPM can then Obsolete cockpit-composer, so the upgrade path would be preserved. 🤔

This does make sense for Fedora though we might run across issues during review as it's not clear which image-builder this is. The name would be consistent with the other package we want to submit for review in Fedora image-builder-cli so I assume we'd get comments like that there first.

@ondrejbudai That might work for RHEL but it'd be very weird to do in Fedora, is there a way we can split this or is it too much maintenance?