Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "wizard: add confirm password to users step (HMS-4903)" #2729

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Jan 8, 2025

Reverts #2709

Reverting because for now we think the UX of the confirm password field is bad. It makes the user do more work for questionable gains - there is already a 'show password' button, so it feels duplicitous.

@lucasgarfield lucasgarfield enabled auto-merge (rebase) January 8, 2025 14:44
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (add3090) to head (967b476).
Report is 2 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
+ Coverage   84.83%   84.86%   +0.03%     
==========================================
  Files         183      183              
  Lines       20823    20795      -28     
  Branches     2019     2019              
==========================================
- Hits        17665    17648      -17     
+ Misses       3136     3125      -11     
  Partials       22       22              
Files with missing lines Coverage Δ
...eateImageWizard/steps/Users/component/UserInfo.tsx 94.04% <ø> (+5.58%) ⬆️
src/store/wizardSlice.ts 89.10% <ø> (+0.65%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e76c6...967b476. Read the comment docs.

@lucasgarfield lucasgarfield force-pushed the revert-2709-add_confirm_password branch from 3fa4ef0 to 967b476 Compare January 8, 2025 18:10
@lucasgarfield lucasgarfield merged commit b3a8597 into main Jan 8, 2025
6 checks passed
@lucasgarfield lucasgarfield deleted the revert-2709-add_confirm_password branch January 8, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants