Add more checks of command line options #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some additional checks of the command line options. Adds warnings for * options ignored when using "flex" output * options ignored when using "null" output * incompatible options setting the output projection The function `opt->get_name(false, true)` used here returns a string with all the (short and long) names of a command line option.
joto
force-pushed
the
check-cmdline-options
branch
from
68ea660 to
d732c3b
Compare
joto
force-pushed
the
check-cmdline-options
branch
from
d732c3b to
d463a63
Compare
pnorman
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three commits add various checks for combinations of command line options which make no sense and so should not be used. For most of these warnings about ignored options are printed (which we can turn into hard fails in a later version of osm2pgsql). For the projection setting options (--latlong, -l, --merc, -m, --proj, and -E) an error is produced, because results are undefined if they are used together.
See individual commits.
Fixes #142