Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Royal Rangers in brands/club/scout #10359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add Royal Rangers in brands/club/scout #10359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions data/brands/club/scout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@
"club": "scout"
}
},
{
"displayName": "Royal Rangers",
"locationSet": {"include": ["001"]},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this "royal" things is suitable for all over the world……maybe you can list some major countries in locationSet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found an overview of the countries in which the Royal Ragers are active. I think there are 76 countries. Should I add them all to the locationSet?

"preserveTags": ["^name"],
"tags": {
"brand": "Royal Rangers",
"brand:wikidata": "Q453731",
"club": "scout"
}
},
{
"displayName": "Scoutisme Béninois",
"id": "scoutismebeninois-7b4b06",
Expand Down
Loading