Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Stage #3986

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Publish Stage #3986

merged 12 commits into from
Dec 2, 2024

Conversation

JoseRFelix
Copy link
Collaborator

Changes

  • Improve unit performance
  • Update Nomic relayers
  • Fix incorrect deposit status display for different wallets
  • Fix misleading countdown phrasing for withdrawal progress
  • Fix confirm swap button is unclickable when 1CT is enabled
  • Fix transfers disappearing after 1 day
  • Change default Osmosis portfolio view from 1D to 7D

deividaspetraitis and others added 11 commits November 27, 2024 18:34
@deividaspetraitis
Update default env variables (#3967)
fd63b30 
* Update default env variables

Updates default env variables pointing to working endpoints
@yury-dubinin
Extracted e2e monitoring tests (#3973)
64e24cb 
* Extracted e2e monitoring tests
@ValarDragon @JoseRFelix
Dev/small speedup to test if we changed right thing (#3977)
2f7e8f7 
* feat: move @keplr-wallet/unit to the repo

* Small speedup to initially test if the change has been applied

* Speedup the clone method by avoiding the constructor call

* Significantly lower math in IntPretty constructor call

* update: gh actions workflow to include unit pkg

---------

Co-authored-by: Jose Felix <[email protected]>
@JoseRFelix
Improve humanize time accuracy (#3976)
ed6aafb 
* feat: improve humanize time accuracy

* fix: build
@ValarDragon
Removes an unneeded sqrt call from CL logic (#3978)
076f5db 
No idea if this is a bottleneck in TRPC/locally.

just noticed it as I was reading through code
@yury-dubinin
Use one pk per zone (#3979)
c787085
@crnbarr93
fix: hide insufficient balance when no wallet connected (#3983)
d0efa9e
@yury-dubinin
Use sparse checkout for e2e tests (#3984)
ed8b51c 
* Use sparse-checkout
@jonator
Merge pull request #3985 from osmosis-labs/master
3c86ea8 
Master -> Stage
@JoseRFelix
General fixes (#3981)
3f1f4c1
@JoseRFelix
(Deposit/Withdraw) Update Nomic Relayers (#3968)
50a682e
@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview ✅ 3 resolved Dec 2, 2024 8:17pm
osmosis-frontend-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:17pm
osmosis-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:17pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 8:17pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Dec 2, 2024 8:17pm

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2024
View reviewed changes
packages/unit/src/coin.ts
export class Coin {
public static parse(str: string): Coin {
const re = new RegExp("([0-9]+)[ ]*([a-zA-Z]+)$");
const execed = re.exec(str);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings with many repetitions of '0'.
packages/unit/src/etc.ts
}

export function isValidDecimalString(str: string): boolean {
return regexDecString.test(str);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetitions of '00'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '0' and with many repetit
@JoseRFelix JoseRFelix requested review from a team December 2, 2024 17:11
@JoseRFelix JoseRFelix merged commit c219ec9 into master Dec 2, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamal-sutra kamal-sutra kamal-sutra approved these changes

@CryptoAssassin1 CryptoAssassin1 CryptoAssassin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JoseRFelix @CryptoAssassin1 @kamal-sutra @deividaspetraitis @yury-dubinin @ValarDragon @crnbarr93 @jonator