feat: 🔧 Add CODE_IDs to Transmuter list #4001
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/server/src/queries/complex/pools/env.tsOops! Something went wrong! :( ESLint: 8.50.0 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/packages/server/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
EnricoBarbieri1997
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
packages/server/src/queries/complex/pools/env.ts(1 hunks)packages/web/config/feature-flag.ts(1 hunks)
🔇 Additional comments (2)
packages/web/config/feature-flag.ts (1)
6-9: LGTM! Good practice adding the deprecation notice.
The deprecation notice properly guides developers to the canonical source of truth in the server package.
packages/server/src/queries/complex/pools/env.ts (1)
4-6: LGTM! Verify the new transmuter pool code IDs.
The addition of new code IDs aligns with the PR objective and should help resolve the Dogeint3 asset display issue.
Let's verify these are valid transmuter contract deployments:
✅ Verification successful
LGTM! The new transmuter pool code IDs are valid.
The verification confirms these are legitimate transmuter pool code IDs:
- The code shows proper integration of transmuter pools in the codebase with 1:1 exchange ratio implementation
- The
TransmuterPoolclass implementation confirms these are stable-swap style pools with zero swap fees - The UI properly identifies and handles these pools as transmuter pools with appropriate icons and routing
- Code IDs are properly validated through the
getCosmwasmPoolTypeFromCodeIdfunction
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the transmuter contract deployments
# Note: Using gh api to query contract info from the chain would be ideal,
# but since we're in a sandbox, we'll search for references in the codebase
# Search for references to these code IDs in the codebase
echo "Searching for references to new transmuter code IDs..."
for id in 814 867 996; do
echo "=== References to code ID $id ==="
rg -l "$id" --type ts --type md
done
# Look for any test files or documentation that might validate these IDs
echo -e "\nSearching for transmuter-related tests and docs..."
rg -l "transmuter" --type ts --type md
Length of output: 4236
Script:
#!/bin/bash
# Let's examine the transmuter-related code to verify these IDs are valid transmuter contracts
# Check the transmuter pool implementation and configuration
echo "=== Checking transmuter pool implementation ==="
ast-grep --pattern 'export class TransmuterPool' -A 20
# Look for any configuration or validation of code IDs
echo -e "\n=== Checking code ID validation logic ==="
rg -A 10 "TransmuterPoolCodeIds" --type ts
# Check for any test cases validating these specific code IDs
echo -e "\n=== Checking test cases for these code IDs ==="
rg -A 5 "(814|867|996).+transmuter" --type ts
Length of output: 4037
Script:
#!/bin/bash
# Let's check the transmuter pool implementation and related files
# Check transmuter pool type definition and implementation
echo "=== Checking transmuter pool implementation ==="
rg -A 10 "cosmwasm-transmuter" --type ts
# Check for any transmuter pool configuration or validation
echo -e "\n=== Checking transmuter configuration ==="
fd transmuter.ts -t f -x cat {}
# Look for any recent changes or commits related to these code IDs
echo -e "\n=== Checking recent changes to transmuter pools ==="
git log -n 5 --oneline -- "**/transmuter*" "**/pools*"
Length of output: 19314
| const TransmuterPoolCodeIds = IS_TESTNET | ||
| ? ["3084"] | ||
| : ["148", "814", "867", "996"]; |
There was a problem hiding this comment.
💡 Codebase verification
Configuration mismatch detected between web and server components
The verification reveals an inconsistency in the TransmuterPoolCodeIds configuration between the web and server components:
- Server (
packages/server/src/queries/complex/pools/env.ts):["148", "814", "867", "996"]for mainnet - Web (
packages/web/config/feature-flag.ts):["148"]for mainnet
This mismatch in pool code IDs between frontend and backend could lead to inconsistent pool type identification and display issues.
🔗 Analysis chain
Verify the impact on pools page rendering.
Since this change aims to fix the Dogeint3 asset display issue on the pools page, we should verify the configuration's impact.
Let's search for related pool page components and Dogeint3 references:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Find related pool page components and Dogeint3 references
echo "Searching for pool page components..."
rg -l "pools.*page" --type ts --type tsx
echo -e "\nSearching for Dogeint3 asset references..."
rg -l "Dogeint3" --type ts --type tsx --type json
Length of output: 334
Script:
#!/bin/bash
# Let's try a different approach without file type restrictions
echo "Searching for pool page components..."
rg -l "pools.*page"
echo -e "\nSearching for Dogeint3 references..."
rg -l "Dogeint3"
echo -e "\nSearching for usages of TransmuterPoolCodeIds..."
rg "TransmuterPoolCodeIds" -A 3
Length of output: 1982
|
Duplicate of #3749 |
What is the purpose of the change:
Add version 3.0, 3.1, 3.2 of the Transmuter contract to the transmuter code_id list
Linear Task
https://linear.app/osmosis/issue/FE-1237/issue-with-dogeint3-asset-displaying-incorrectly-in-pools-page
Brief Changelog
Notice
This can be closed #3749