-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRE-2386: use latest ARC #2
Conversation
Reviewer's Guide by SourceryThis PR updates the CI workflow configuration to use a custom runner ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lilfrou - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more context in the PR description about why we're switching from ubuntu-latest to utility-staging-amd64. What are the benefits or requirements driving this change?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -9,7 +9,7 @@ jobs: | |||
|
|||
build: | |||
name: Build | |||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 question (security): Consider security and reproducibility implications of using a custom runner
Custom runners can introduce security risks and might affect build reproducibility. Could you explain the rationale for switching from the standard ubuntu-latest runner?
Linear Ticket
SRE-2386
Overview
Areas to focus on
Summary by Sourcery
CI: