Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-2386: use latest ARC #2

Merged
merged 1 commit into from
Dec 11, 2024
Merged

SRE-2386: use latest ARC #2

merged 1 commit into from
Dec 11, 2024

Conversation

lilfrou
Copy link

@lilfrou lilfrou commented Dec 11, 2024

Linear Ticket

SRE-2386

Overview

  • use latest ARC

Areas to focus on

  • use utility-staging-amd64

Summary by Sourcery

CI:

  • Change the CI workflow to run on 'utility-staging-amd64' instead of 'ubuntu-latest'.

Copy link

linear bot commented Dec 11, 2024

@lilfrou lilfrou self-assigned this Dec 11, 2024
Copy link

sourcery-ai bot commented Dec 11, 2024

Reviewer's Guide by Sourcery

This PR updates the CI workflow configuration to use a custom runner (utility-staging-amd64) instead of the default ubuntu-latest runner for the build job.

File-Level Changes

Change Details Files
Updated GitHub Actions runner configuration
  • Changed the build job runner from ubuntu-latest to utility-staging-amd64
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lilfrou - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context in the PR description about why we're switching from ubuntu-latest to utility-staging-amd64. What are the benefits or requirements driving this change?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -9,7 +9,7 @@ jobs:

build:
name: Build
runs-on: ubuntu-latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 question (security): Consider security and reproducibility implications of using a custom runner

Custom runners can introduce security risks and might affect build reproducibility. Could you explain the rationale for switching from the standard ubuntu-latest runner?

@lilfrou lilfrou merged commit 6a59a62 into master Dec 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant