Only try to set flag_value if is_flag is true #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This statement:
flag_value = not self.default
requires the class to have a working `__bool__` method. However,
there are some classes that explicitly disable this method:
- [`numpy.ndarray`](https://numpy.org/doc/stable/reference/arrays.ndarray.html)
raises `ValueError: The truth value of an array with more than
one element is ambiguous. Use a.any() or a.all()`
- [`astropy.units.Quantity`](https://docs.astropy.org/en/stable/api/astropy.units.Quantity.html)
raises `ValueError: Quantity truthiness is ambiguous, especially
for logarithmic units and temperatures. Use explicit comparisons.`
Move this statement so that it is only executed if `is_flag` is
true.
|
See, for example, m4opt/m4opt#220. |
|
This seems to make sense. Thank you! Here it would make sense to have some typing to clarify this requirement. Though that's out of scope for this PR. |
|
Thanks for the speedy review, and happy holidays! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This statement:
requires the class to have a working
__bool__method. However, there are some classes that explicitly disable this method:numpy.ndarrayraisesValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()astropy.units.QuantityraisesValueError: Quantity truthiness is ambiguous, especially for logarithmic units and temperatures. Use explicit comparisons.Move this statement so that it is only executed if
is_flagis true.