Relax meson pins in CI #60681
Open
Relax meson pins in CI #60681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Jan 8, 2025
| @@ -3,7 +3,7 @@ | |||
| # See https://github.com/scipy/scipy/pull/12940 for the AIX issue. | |||
| requires = [ | |||
| "meson-python>=0.13.1", | |||
| "meson>=1.2.1,<2", | |||
| "meson>=1.2.1", | |||
There was a problem hiding this comment.
I removed the <2 as I didn't want to repeat it everywhere in our CI configurations, and we don't create upper bounds like this on any other dependency. There also is not a meson 2.0 under development
|
Ah so I guess the pinned versions here were suppressing compiler errors in some fashion. Looks like #60674 will need to happen before this |
WillAyd
force-pushed
the
remove-meson-pins
branch
from
06481f0 to
348cb4d
Compare
WillAyd
force-pushed
the
remove-meson-pins
branch
from
618e4cd to
05c4c12
Compare
WillAyd
force-pushed
the
remove-meson-pins
branch
from
41c2b59 to
3e200a6
Compare
WillAyd
commented
Jan 9, 2025
| @@ -159,6 +158,12 @@ test-command = """ | |||
| free-threaded-support = true | |||
| before-build = "PACKAGE_DIR={package} bash {package}/scripts/cibw_before_build.sh" | |||
|
|
|||
| [tool.cibuildwheel.macos] | |||
| environment = {LDFLAGS="-Wl,--strip-all"} | |||
There was a problem hiding this comment.
These flags are not applicable on windows and were causing the linker to throw an error when combined with -Werror in our CI
|
I believe the remaining issues appeared with meson-python 0.16.0. Reported upstream in mesonbuild/meson-python#716 May need to put an upper limit on the 0.15.0 release for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #60089 we relaxed the meson pin in our pyproject, but all of our CI still hard codes the minimum version. This updates it to treat the meson dependencies the same way as Cython, i.e. newer versions are used in CI