Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
gui1117 committed Jan 2, 2025
1 parent 2147529 commit d40106a
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions prdoc/pr_7028.prdoc
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
title: '[draft] Make `TransactionExtension` tuple of tuple transparent for implication'
title: 'Fix implication order in implementation of `TransactionExtension` for tuple'
doc:
- audience:
- Runtime Dev
- Runtime User
description: |-
Currently `(A, B, C)` and `((A, B), C)` change the order of implications in the transaction extension pipeline. This order is not accessible in the metadata, because the metadata is just a vector of transaction extension, the nested structure is not visible.
Before this PR, the implications were different in the pipeline `(A, B, C)` and `((A, B), C)`.
This PR fixes this behavior and make nested tuple transparant, the implication order of tuple of tuple is not same as a single tuple.

This PR make the implementation for tuple of `TransactionExtension` better for tuple of tuple. `(A, B, C)` and `((A, B), C)` don't change the implication for the validation A.

This is a breaking change but only when using the trait `TransactionExtension` the code implementing the trait is not breaking (surprising rust behavior but fine).
This breaks usage of `TransactionExtension::validate`.
TODO TODO: explain how to fix the code
crates:
- name: pallet-skip-feeless-payment
bump: major
- name: sp-runtime
bump: major

0 comments on commit d40106a

Please sign in to comment.