Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-authorship to umbrella crate #6620

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Migrate pallet-authorship to umbrella crate #6620

wants to merge 24 commits into from
+3,142 −2,796

Conversation

runcomet
Copy link
Contributor

@runcomet runcomet commented Nov 22, 2024 •
edited
Loading

Part of #6504

Review Notes

Adhering to the goal that prelude imports contain only those modules that are widely used across multiple pallets within the frame umbrella crate.

account: This module encompasses various account management traits. It includes functionality for handling account-related operations.

polkadot address: 14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 23, 2024

User @runcomet, please sign the CLA here.

@runcomet runcomet marked this pull request as ready for review November 23, 2024 02:28
@runcomet runcomet requested a review from a team as a code owner November 23, 2024 02:28
@re-gius re-gius added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Nov 27, 2024
@runcomet
Copy link
Contributor Author

@re-gius recent push corrects the try-runtime feature flag in the Cargo.toml file

@runcomet runcomet mentioned this pull request Dec 2, 2024
Open
91 tasks
@re-gius re-gius added the R0-silent Changes should not be mentioned in any release notes label Dec 9, 2024
re-gius
re-gius requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the guidelines from here

I should mainly work with preludes and add items to then when possible.

substrate/frame/authorship/Cargo.toml Outdated Show resolved Hide resolved
@runcomet
Copy link
Contributor Author

please review @re-gius

re-gius
re-gius reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just undo changes to the Cargo.lock file and then ping me for an approval

Cargo.lock Outdated
@@ -1396,7 +1396,7 @@ dependencies = [
"futures-lite 2.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo changes to this file since it is not relevant to the PR

@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 9, 2025 19:54
@runcomet
Copy link
Contributor Author

runcomet commented Jan 9, 2025

please review @re-gius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runcomet @re-gius