salary pallet migration to umbrella crate #7025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemantaggarwal
added
R0-silent
re-gius
reviewed
Jan 2, 2025
UtkarshBhardwaj007
requested changes
Jan 2, 2025
| @@ -22,10 +22,9 @@ | |||
| use super::*; | |||
| use crate::Pallet as Salary; | |||
|
|
|||
| use frame_benchmarking::v2::*; | |||
| use frame_system::{Pallet as System, RawOrigin}; | |||
| use sp_core::Get; | |||
There was a problem hiding this comment.
Suggested change
| use sp_core::Get; | |
| use frame::deps::sp_core::Get; |
substrate/frame/salary/Cargo.toml
Outdated
| "frame-benchmarking?/std", | ||
| "frame-support/experimental", | ||
| "frame-support/std", | ||
| "frame-system/std", | ||
| "log/std", | ||
| "pallet-ranked-collective/std", | ||
| "scale-info/std", | ||
| "sp-arithmetic/std", |
There was a problem hiding this comment.
Suggested change
| "sp-arithmetic/std", |
| @@ -194,7 +193,7 @@ fn swap_exhaustive_works() { | |||
|
|
|||
| // The events mess up the storage root: | |||
| System::reset_events(); | |||
| sp_io::storage::root(sp_runtime::StateVersion::V1) | |||
| sp_io::storage::root( frame::deps::sp_runtime::StateVersion::V1) | |||
There was a problem hiding this comment.
Instead of using the whole path here, let's import this at the top and then use it.
seemantaggarwal
requested review from
acatangiu,
sorpaas,
koute and
a team
as code owners
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Closing this in favour of https://github.com/paritytech/polkadot-sdk/pull/7048/commits |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
# Description Migrating salary pallet to use umbrella crate. It is a follow-up from #7025 Why did I create this new branch? I did this, so that the unnecessary cargo fmt changes from the previous branch are discarded and hence opened this new PR. ## Review Notes This PR migrates pallet-salary to use the umbrella crate. Added change: Explanation requested for why `TestExternalities` was replaced by `TestState` as testing_prelude already includes it `pub use sp_io::TestExternalities as TestState;` I have also modified the defensive! macro to be compatible with umbrella crate as it was being used in the salary pallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in this
document and fill out the
sections below. Once you're ready to submit your PR for review, please delete this section and leave only the text under
the "Description" heading.
Description
Migrating salary pallet to use umbrella crates
Review Notes
This PR migrates pallet-salary to use the umbrella crate.
✄ -----------------------------------------------------------------------------