-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple transaction extension version in UncheckedExtrinsic
type.
#7035
Open
gui1117
wants to merge
33
commits into
master
Choose a base branch
from
gui-transaction-extension-multiple-version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,233
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension-multiple-version
…ension-multiple-version
…ension-multiple-version
gui1117
added
the
T17-primitives
Changes to primitives that are not covered by any other label.
label
Jan 8, 2025
gui1117
changed the title
[Draft] allow multiple transaction extension version in
Allow multiple transaction extension version in Jan 8, 2025
UncheckedExtrinsic
type.UncheckedExtrinsic
type.
All GitHub workflows were cancelled due to failure one of the required jobs. |
gui1117
force-pushed
the
gui-transaction-extension-multiple-version
branch
from
January 8, 2025 11:51
8e5bd74
to
a59da7b
Compare
PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
T17-primitives
Changes to primitives that are not covered by any other label.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhance
UncheckedExtrinsic
type with a new optional generic:ExtensionOtherVersion
.This generic defaults to
InvalidVersion
meaning there is not other version than the regular version 0. This is the same behavior as before this PR.New feature
To use this new feature, you can use the new types
TxExtLineAtVers
andMultiVersion
to define a transaction extension with multiple version:Breaking change
The types
Preamble
,CheckedExtrinsic
andExtrinsicFormat
also have this new optional generic. Their type definition also have changed a bit, theGeneral
variant was 2 fields, the version and the extension, it is now only one field, the extension, and the version can be retrieve by callingextension.version()
The type inference for those types may fail because of this PR, to update the code, write some partial type:
UncheckedExtrinsic<_, _, _, _>
,Preamble<_, _, _>
,ExtrinsicFormat<_, _> and
CheckedExtrinsic<_, _, _>`.Alternative implementation
This PR breaks the types a bit, I think it is very minimal and fine, but if this is annoying we can still keep the old types and write new types such as
UncheckedExtrinsicV2
,CheckedExtrinsicV2
etc..