Migrate pallet-mmr to umbrella crate #7081
Open
+142
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 tasks
acatangiu
added
R0-silent
acatangiu
reviewed
Jan 8, 2025
.gitignore
Outdated
| @@ -41,3 +41,5 @@ substrate.code-workspace | |||
| target/ | |||
| *.scale | |||
| justfile | |||
| python-venv | |||
| .zed | |||
There was a problem hiding this comment.
This is a bit obscure, maybe add .zed file to your global gitignore configuration?
Suggested change
| .zed |
| frame-benchmarking = { optional = true, workspace = true } | ||
| frame-support = { workspace = true } | ||
| frame-system = { workspace = true } | ||
| frame = { workspace = true, features = ["experimental", "runtime"] } |
There was a problem hiding this comment.
what is the experimental feature for?
There was a problem hiding this comment.
I just follow other PRs. Yeah, it's a bit confusing, it won't compile after removing the feature.
polkadot-sdk git:(migrate-pallet-mmr) ✗ cargo check -p pallet-mmr
...
error[E0433]: failed to resolve: could not find `deps` in `frame`
--> substrate/frame/merkle-mountain-range/src/lib.rs:65:2
|
65 | deps::sp_mmr_primitives::{
| ^^^^ could not find `deps` in `frame`
...
68 | prelude::*,
| ^^^^^^^ could not find `prelude` in `frame`
...
Same concern in #6504 (comment)
yrong
changed the title
bkchr
reviewed
Jan 9, 2025
| deps::sp_mmr_primitives::{ | ||
| self as primitives, utils, utils::NodesUtils, Error, LeafDataProvider, LeafIndex, NodeIndex, | ||
| }, | ||
| prelude::*, |
There was a problem hiding this comment.
This should not be exported publicly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504