Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth-rpc 1017003 runtime upgrade fix #7097

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Jan 9, 2025

Fix eth-rpc metadatafor 1017003 asset-hub westend

@pgherveou pgherveou changed the base branch from master to stable2412 January 9, 2025 09:33
@pgherveou pgherveou marked this pull request as ready for review January 9, 2025 09:35
Copy link

github-actions bot commented Jan 9, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev added the R0-silent Changes should not be mentioned in any release notes label Jan 9, 2025
@pgherveou pgherveou requested review from a team as code owners January 9, 2025 10:01
@EgorPopelyaev
Copy link
Contributor

/cmd prdoc --audience runtime_dev --bump none --verify false

Copy link

github-actions bot commented Jan 9, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev
Copy link
Contributor

/cmd prdoc --audience runtime_dev --bump no_change --verify false

@EgorPopelyaev EgorPopelyaev merged commit 268a928 into stable2412 Jan 9, 2025
152 of 188 checks passed
@EgorPopelyaev EgorPopelyaev deleted the 1017003-eth-rpc branch January 9, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants