Migrate pallet-statement to use umbrella crate #7106
+3,586
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @Nathy-bajo, please sign the CLA here. |
|
Please review @re-gius @kianenigma |
kianenigma
reviewed
Jan 10, 2025
| @@ -0,0 +1,21 @@ | |||
| thread 'coordinator' panicked at /rustc/f7273e0044ad8f35ad27282e4ab776af50b61a54/compiler/rustc_codegen_ssa/src/back/write.rs:1662:29: | |||
kianenigma
reviewed
Jan 10, 2025
| use sp_core::Pair; | ||
| use sp_runtime::{traits::IdentityLookup, AccountId32, BuildStorage}; | ||
| use frame::testing_prelude::*; | ||
| use frame::deps::{sp_runtime::{traits::IdentityLookup, AccountId32, BuildStorage}, sp_core::Pair}; |
There was a problem hiding this comment.
Most of this stuff should already be testing prelude.
kianenigma
reviewed
Jan 10, 2025
| use sp_core::Pair; | ||
| use sp_runtime::AccountId32; | ||
| use sp_statement_store::{ | ||
| use frame::deps::{sp_runtime::AccountId32, sp_core::{Pair, H256}, sp_statement_store::{ |
kianenigma
reviewed
Jan 10, 2025
| @@ -569,7 +569,8 @@ pub mod deps { | |||
| pub use sp_core; | |||
| pub use sp_io; | |||
| pub use sp_runtime; | |||
|
|
|||
| pub use sp_statement_store; | |||
There was a problem hiding this comment.
All of the primitives of the statemnt store are really just used in one pallet, I would not add them here and keep them as a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504