-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature to request reviewers #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mordamax
reviewed
Oct 30, 2023
mordamax
approved these changes
Oct 30, 2023
Co-authored-by: Maksym H <[email protected]>
Merged
Bullrich
added a commit
that referenced
this pull request
Oct 31, 2023
Bullrich
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Oct 31, 2023
This version includes paritytech/review-bot#97 which can assign reviewers. It will be the final replacement for PRCR. It also moves the secrets to the environment master.
Bullrich
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Nov 1, 2023
This version includes paritytech/review-bot#97 which can assign reviewers. It will be the final step required to replace PRCR. It also moves the secrets to the environment master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the feature to request reviewers. For this we are using a github app with pull request write permission (I need to request our app to be updated).
I will be making a following PR to merge the keys as we are using the same key for all the github classes.
The request feature is disabled by default.
Resolves #53