Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[network] fix: always set Kademlia mode to server #14703

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Aug 2, 2023

otherwise, the DHT connectivity drops significantly as the graphs of our internal cluster showed.

PR where the regression was introduced: #14429

otherwise, connectivity drops significantly.
@melekes melekes self-assigned this Aug 2, 2023
@melekes melekes added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 2, 2023
@melekes melekes requested a review from a team August 2, 2023 15:31
@dmitry-markin dmitry-markin requested a review from a team August 2, 2023 15:35
@vstakhov
Copy link
Contributor

vstakhov commented Aug 3, 2023

I have tested this PR on Versi and it seems to have fixed the connectivity issues and DHT misses.

Copy link
Contributor

@altonen altonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstakhov thanks for running the burn-in

@altonen
Copy link
Contributor

altonen commented Aug 3, 2023

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants