Skip to content

Exported graphs pass the validator and redraw two-way links once (#304) - #308

Merged
patrickchugh merged 1 commit into
mainfrom
fix/304-exported-graph-warnings
Nov 20, 2026
Merged

patrickchugh merged 1 commit into
mainfrom
fix/304-exported-graph-warnings

Conversation

@patrickchugh

Copy link
Copy Markdown
Owner

Two nodes that list each other now draw one line with an arrowhead at each end, from Terraform and from a graph file alike (the deferred drawing path drew such pairs twice). The validator knows TerraVision's hidden types and no longer warns about two-way pairs. Docs updated.

Hybrid-network export: 28 validator warnings to 0, and it redraws like the Terraform drawing except the Internet arrowhead. Full suite: 3,046 passed locally. No release: rolls into the next one (skill docs changed, so the plugin bump goes with it).

Closes #304

- Two nodes that list each other draw one line with an arrowhead at each
  end, from Terraform and from a graph file alike. The deferred drawing
  path had no duplicate check, so such a pair drew two lines.
- The validator knows the types TerraVision hides (route tables, firewall
  policies, IAM grants...) and no longer calls them unknown, and no longer
  warns about two-way pairs.
- Graph Format docs and the skill say how two-way links draw.

The hybrid-network export goes from 28 validator warnings to none and
redraws like the Terraform drawing, apart from the Internet arrow (drawn
two-way from Terraform by AWS_BIDIRECTIONAL_NODES).

Closes #304
@sonarqubecloud

Copy link
Copy Markdown

@patrickchugh
patrickchugh merged commit 13234c0 into main Nov 20, 2026
9 checks passed
@patrickchugh
patrickchugh deleted the fix/304-exported-graph-warnings branch November 20, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graphs exported from Terraform still fail the validator: unknown types and two-way links

1 participant