Repository navigation
Exported graphs pass the validator and redraw two-way links once (#304) - #308
Merged
Merged
Conversation
- Two nodes that list each other draw one line with an arrowhead at each end, from Terraform and from a graph file alike. The deferred drawing path had no duplicate check, so such a pair drew two lines. - The validator knows the types TerraVision hides (route tables, firewall policies, IAM grants...) and no longer calls them unknown, and no longer warns about two-way pairs. - Graph Format docs and the skill say how two-way links draw. The hybrid-network export goes from 28 validator warnings to none and redraws like the Terraform drawing, apart from the Internet arrow (drawn two-way from Terraform by AWS_BIDIRECTIONAL_NODES). Closes #304
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Two nodes that list each other now draw one line with an arrowhead at each end, from Terraform and from a graph file alike (the deferred drawing path drew such pairs twice). The validator knows TerraVision's hidden types and no longer warns about two-way pairs. Docs updated.
Hybrid-network export: 28 validator warnings to 0, and it redraws like the Terraform drawing except the Internet arrowhead. Full suite: 3,046 passed locally. No release: rolls into the next one (skill docs changed, so the plugin bump goes with it).
Closes #304