Merge pull request #133 from paulsengroup/fix/msvc

Bring back compatibility with recent versions of MSVC
paulsengroup · Nov 30, 2024 · ceeeda8 · ceeeda8
2 parents af46902 + dfb8f1b
commit ceeeda8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/.github/workflows/pip.yml b/.github/workflows/pip.yml
@@ -46,7 +46,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [windows-2019, macos-latest, ubuntu-latest]
+        os: [windows-2022, macos-latest, ubuntu-latest]
         python-version: ["3.9", "3.13"]
 
     runs-on: ${{ matrix.os }}

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -159,14 +159,4 @@ if(WIN32)
   )
 endif()
 
-if(MSVC)
-  if(MSVC_VERSION GREATER 1939)
-    message(
-      FATAL_ERROR
-      "MSVC versions after 19.39.33523.0 (and at least up to 19.42.34321.1) are known to produce broken hictkpy wheels. Please try again using MSVC 19.39.33523.0 (Visual Studio 17.9) or older."
-    )
-  endif()
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj")
-endif()
-
 add_subdirectory(src)