Rails 3.1.0+ compatibility (and a few other minor improvements) #32

Empact · 2011-12-19T14:46:29Z

Hey there,

I made some improvements to spatial adapter to get it working under Rails 3.1.0 for my own use, and posted about fork here: #26

Several people have confirmed that it works for them and one has suggested a pull request, so here it is.

One issue, which I noted in my original comment to that thread:

I have a working fix, but still an outstanding issue or two. Most notably, the schema dumper doesn't seem to be picking up its extensions, when run from within my rails project. The schema dumper specs pass.

Also note I've only been testing on postgres.

…odule, with most methods relying directly on super rather than aliasing. Have some failures when moving the rest - not sure why.

…wn to 24 from 46

…n until after active record has been loaded.

…oncern module, with most methods relying directly on super rather than aliasing. Have some failures when moving the rest - not sure why." Was having trouble with module methods not overriding the base methods after inclusion - not sure what the cause for that was. This reverts commit 9a2a657. Conflicts: lib/spatial_adapter/postgresql.rb

…, as is done in the rails 3.1 codebase

… detect their success, and properly remove the created indices

Empact added 13 commits August 14, 2011 16:15

Support rspec 2 for development

67d0a74

Use method-level rescues for simplicity

2f39602

Don't capture exceptions into locals if we're not going to use them.

8ea88fb

Tidy up the postgres adapter a bit

1344bf0

Allow testing with activerecord > 3.0.3

ad7b9b8

move the postgres adapter extensions into an ActiveSupport::Concern m…

9a2a657

…odule, with most methods relying directly on super rather than aliasing. Have some failures when moving the rest - not sure why.

Introduce type_cast for our postgres adapter, cutting our failures do…

8fa78c9

…wn to 24 from 46

Fix that native_database_types wasn't being properly overridden

3126e19

Try to fix the native_database_types by delaying the adapter inclusio…

bcac321

…n until after active record has been loaded.

Use explicit inner joins to add tables in the postgres indexes lookup…

868b609

…, as is done in the rails 3.1 codebase

Compact away the nil columns in postgres #indexes, as they do in 3.1

fd09f85

Fix the postgres add_index specs to use #indexes rather than mocks to…

d64ac1c

… detect their success, and properly remove the created indices

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rails 3.1.0+ compatibility (and a few other minor improvements) #32

Rails 3.1.0+ compatibility (and a few other minor improvements) #32

Empact commented Dec 19, 2011

Rails 3.1.0+ compatibility (and a few other minor improvements) #32

Are you sure you want to change the base?

Rails 3.1.0+ compatibility (and a few other minor improvements) #32

Conversation

Empact commented Dec 19, 2011