Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade multus to v4.1.3-thick and migrate config #104

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

scoquelin
Copy link
Contributor

@scoquelin scoquelin commented Oct 17, 2024

This PR allows to migrate to multus v4.1.3-thick with kustomize by :

  • explicitly overriding image/tag to use ghcr.io/k8snetworkplumbingwg/multus-cni:v4.1.3-thick
  • overriding default multus-daemon-config ConfigMap with custom values extracted from previous container args config
  • removing overlay for container args (not needed anymore since config is now injected through ConfigMap)

Closes #101

@scoquelin scoquelin requested review from josmo and chomatdam October 17, 2024 22:19
@chomatdam
Copy link
Contributor

chomatdam commented Oct 18, 2024

@scoquelin gist here to test it in Pelotech cluster - you just have to update pelotech/infrastructure kustomization to point to your Multus branch only for the Multus component, and apply the gist

EDIT: we'll probably want an extra test with a 2nd VM or a container to validate the network connectivity

@scoquelin scoquelin force-pushed the upgrade-multus-4.x branch 3 times, most recently from c8c7f0f to b4ba2e7 Compare October 23, 2024 01:14
@scoquelin scoquelin merged commit a479045 into main Oct 23, 2024
1 check passed
@scoquelin scoquelin deleted the upgrade-multus-4.x branch October 23, 2024 18:59
chomatdam added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Multus to v4.x
2 participants