-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibc-types: update to v0.14.0 #4682
Labels
consensus-breaking
breaking change to execution of on-chain data
needs-refinement
unclear, incomplete, or stub issue that needs work
Comments
github-actions
bot
added
the
needs-refinement
unclear, incomplete, or stub issue that needs work
label
Jun 28, 2024
This was referenced Jul 17, 2024
conorsch
added
the
consensus-breaking
breaking change to execution of on-chain data
label
Oct 8, 2024
Thanks for adding this tag @conorsch, it's indeed a (small) consensus breaking change since we amended one of the messages modeling the IBC protocol (following |
This was done in #4973 reasoning: #4963 (comment) |
conorsch
pushed a commit
that referenced
this issue
Jan 10, 2025
Continuation of #4963, into a release branch `v0.82.x` before tagging a release candidate at that version and publishing the workspace using an `alpha` version. This handles the domain type change for upgradeable channels (penumbra-zone/ibc-types#84) smoothly. It makes sure to write default values to the new fields, which avoids wire protocol changes, and makes this PR non consensus/state breaking. Includes substantial version changes to: * tendermint-rs * tonic #4400 * ibc-types #4682 * cnidarium #4956 --------- Co-authored-by: Richard Janis Goldschmidt <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consensus-breaking
breaking change to execution of on-chain data
needs-refinement
unclear, incomplete, or stub issue that needs work
As of
v0.78.0
(#4582), the monorepo is still depending onibc-types
version0.12.0
: https://github.com/penumbra-zone/penumbra/blob/v0.78.0/Cargo.toml#L156We've merged some upstream work in ibc-types since, e.g. penumbra-zone/ibc-types#88 & penumbra-zone/ibc-types#84, the latter of which looks like it may be state-breaking. We should make a plan to update the monorepo to the latest version of ibc-types, including writing migrations if necessary.
The text was updated successfully, but these errors were encountered: