Repository navigation
Conversation
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
jgbernalp
force-pushed
the
ui-customization
branch
from
October 13, 2026 11:46
56c5a50 to
3eaff7f
Compare
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
force-pushed
the
zhuje/ou1569-ui-customization-textfield
branch
from
October 13, 2026 22:47
ca8ce96 to
04e6bea
Compare
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
force-pushed
the
zhuje/ou1569-ui-customization-textfield
branch
from
October 13, 2026 22:56
04e6bea to
4df8573
Compare
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
TextFieldprimitive tocomponents/src/next/primitives, continuing the UI customization series see perses/perses#3570 for background.Built on Base UI's
Field(Root/Label/Control/Description), styled entirely through design tokens under@layer perses.components, with size/status driven bydata-size/data-statusattributes.API (everything else flows through native
InputHTMLAttributesspread —value,onChange,placeholder,disabled,readOnly,required, etc.):label/helperText— form label (wired viahtmlFor) and description slotsstatus—error | warning | success | info, from the new sharedStatustypesize—xs | sm | md | lg, from the new sharedSizetypefullWidthwidth— responsive: accepts a plain CSS width or a per-breakpoint object ({ default, xs, sm, md, lg, xl })multiline+rows— renders a<textarea>viaField.Control'srenderpropstartAdornment/endAdornment— genericReactNodeslotsThe prop surface was derived from auditing all MUI
TextFieldcall sites across perses/shared and perses/perses (87×fullWidth, 72×error, 28×helperText, 17×multiline, 14×size, plus adornments viaInputProps) — only props with real usage are implemented. MUI'sselect,variant, andmarginare intentionally omitted (selectwill be its own primitive; the others are superseded by design tokens).Responsiveness: reuses the shared responsive system introduced in #299 (
primitives/system/responsive.ts+responsive.css). The two system files are included here byte-identical to #299, so whichever PR merges first, the other merges cleanly with no conflict. Plainwidthvalues render as inline style; responsive objects emit--ps-responsive-width-<breakpoint>CSS variables consumed by the sharedps-responsive-widthclass — same pattern asBox.Also included:
primitives/types.tswithSizeandStatus— single source of truth for future primitives (per feedback on [FEATURE] UI Customization. Add Chip primitive component #320/[FEATURE] UI Customization. Checkbox primitive component. #332).TextFieldregistered inPersesComponentsusing theRefComponenttyping from [FEATURE] UI customization. Add IconButton #312, souseComponents()consumers get a correctly typedHTMLInputElement | HTMLTextAreaElementref.Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: