Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues (#87,#22,#46) #23

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

peterk87
Copy link
Owner

  • fix: better handling of empty IRMA consensus sequences to avoid downstream analysis errors with VADR and BLASTN (peterk87/nf-flu #22)
  • fix: Clair3 versions.yml indentation issue (#87)
  • fix: removed capturing of cat and gzip versions in CAT_ILLUMINA_FASTQ process (#46) to avoid issue in some execution environments.
  • docs: update README.md

TODO

  • Update Nanopore CI test with user-defined Clair3 model to ensure no regression of issue #87

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test_{illumina,nanopore},docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

* fix: better handling of empty IRMA consensus sequences to avoid downstream analysis errors with VADR and BLASTN ([peterk87/nf-flu #22](#22))
* fix: Clair3 `versions.yml` indentation issue ([#87](CFIA-NCFAD#87))
* fix: removed capturing of cat and gzip versions in CAT_ILLUMINA_FASTQ process ([#46](CFIA-NCFAD#46)) to avoid issue in some execution environments.
* docs: update README.md
@peterk87 peterk87 merged commit 81d4823 into dev Oct 21, 2024
6 checks passed
@peterk87 peterk87 deleted the fix/87-and-cat-noempty-irma-consensus-seqs branch October 21, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant