Repository navigation
fix(iam): retain revocation versions through replay and recovery - #192
Merged
Merged
Conversation
Signed-off-by: Feng Ruohang <rh@vonng.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
Retain source-ordered tombstones and parent grant boundaries across both IAM backends, cache reloads, and deliberate identity recreation. Reconcile deletions through a versioned, bounded replication protocol with restart-aware acknowledgements. Cover inherited group grants, STS retention, same-key service recreation, absolute expiration, and failures after the durable commit. Document coordinated upgrades and the remaining consistency boundaries. Signed-off-by: Feng Ruohang <rh@vonng.com>
Keep one healing loop per process across replication configuration reloads. Reacquire leadership after a lease is canceled and allow shutdown while waiting, so temporary quorum loss cannot permanently stop revocation propagation. Signed-off-by: Feng Ruohang <rh@vonng.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
Vonng
force-pushed
the
codex/iam-peer-delete-reload
branch
from
September 15, 2026 14:59
230464c to
dff81f2
Compare
Vonng
force-pushed
the
codex/iam-revision-tombstones
branch
from
September 15, 2026 14:59
785323d to
7b4cacc
Compare
Vonng
marked this pull request as ready for review
September 15, 2026 15:11
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
An offline site can replay deleted IAM identities and policy mappings after their deletion versions have disappeared from storage. Periodic healing can then restore access that an administrator revoked. This change retains source-ordered revocations across storage reloads and rejects older identities and grants while allowing deliberate newer recreation.
Depends on #191; merge that first. The first phase alone does not close R3.
Implementation
No dependency changes or unrelated deadline changes are included.
Validation and review
go test -p 4 -tags kqueue,dev ./...passed: 6142 leaf tests, 166 existing conditional skips, zero failures; a disposable real etcd endpoint was enabled.claude-opus-5, max effort, read-only reviews recommend merging the code with no remaining P1/P2 findings in the covered scope. Runtime validation is separate from that review.Upgrade and limits
Requires coordinated upgrades across participating sites and sibling nodes. Mixed old/new servers sharing the IAM backend are unsupported. Preserve deletion history in backups; clearing tombstones is not a safe downgrade procedure. The 30-second healing interval is not a convergence SLA. An intermediate object-backend experiment exceeded its original 95-second observation window; that failure was retained. Diagnosis identified initial leader-lock backoff and independently reproduced permanent healing-loop exit on lease loss. The latter is fixed; final experiments use a 240-second observation window without changing the production retry timing.
Ordinary live-group member-removal conflicts, per-token cross-site
RevokeTokens, and arbitrary clock/equal-timestamp conflicts are not new guarantees. See the design and operational notes.