Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 637 improve test framework #638

Merged
merged 18 commits into from
Mar 5, 2023
Merged

Issue 637 improve test framework #638

merged 18 commits into from
Mar 5, 2023

Conversation

PeiMu
Copy link
Collaborator

@PeiMu PeiMu commented Jan 30, 2023

address #637

@PeiMu
sync issue-633
102f839 
* Issue-637---improve-test-framework.
@PeiMu PeiMu self-assigned this Jan 30, 2023
@PeiMu PeiMu linked an issue Jan 30, 2023 that may be closed by this pull request
Improve test framework #637
Open
@PeiMu
Copy link
Collaborator Author

PeiMu commented Jan 30, 2023

The test framework would be better base on the newest version of the compiler, so I merged #634 here.

PeiMu added 9 commits January 30, 2023 21:18
@PeiMu
merge master
7385c61 
* Issue-637---improve-test-framework.
@PeiMu
rewrite test framework with tic-tok
9451fc5 
* Issue-637---improve-test-framework.
@PeiMu
clone a dummy function for functions that are generated before
0195e14 
* Issue-637---improve-test-framework.
@PeiMu
remove the children functions if the parent function has been deleted
1d37394 
* Issue-637---improve-test-framework.
@PeiMu
remove from callerMap when the function is deleted; always keep the '…
649a2d8 
…important' function to the bottomer pos than 'dummy' or 'new' one

* Issue-637---improve-test-framework.
@PeiMu
remove unused functions
0284fa9 
* Issue-637---improve-test-framework.
@PeiMu
the range of GEP can be negative; the range of SHR cannot be negative
f0821bf 
* Issue-637---improve-test-framework.
@PeiMu
the range of GEP can be negative; the range of SHR cannot be negative
9132381 
* Issue-637---improve-test-framework.
@PeiMu
use a flag to control
ef50ec5 
* Issue-637---improve-test-framework.
@PeiMu PeiMu requested a review from KomaGR February 9, 2023 18:23
@PeiMu
Copy link
Collaborator Author

PeiMu commented Feb 9, 2023

Could you please review and merge this PR? @KomaGR @blackgeorge-boom

@PeiMu
fix bug of issue-639
6449464 
* Issue-637---improve-test-framework.
@PeiMu
Copy link
Collaborator Author

PeiMu commented Feb 9, 2023

Easily fix Issue #639 here.

@PeiMu PeiMu mentioned this pull request Feb 9, 2023
Closed
PeiMu added 4 commits February 10, 2023 13:05
@PeiMu
reset bmx055yAcceleration
0864c59 
* Issue-637---improve-test-framework.
@PeiMu
fix the result error of sincosf, but the performance become worse. Ch…
6169327 
…eck issue 641

* Issue-637---improve-test-framework.
@PeiMu
reconstruct auto_test, and collect timer info
4bfa2d0 
* Issue-637---improve-test-framework.
@PeiMu
get the function results
9af0329 
* Issue-637---improve-test-framework.
KomaGR
KomaGR requested changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@KomaGR KomaGR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on Slack.

PeiMu added 2 commits February 14, 2023 20:42
@PeiMu
add timer collection and correctness check to the test framework
bf69474 
* Issue-637---improve-test-framework.
@PeiMu
reformat code
c96fd9b 
* Issue-637---improve-test-framework.
@PeiMu
Copy link
Collaborator Author

PeiMu commented Feb 15, 2023

Please see my comments on Slack.

done. please check and merge it.

@PeiMu PeiMu requested a review from KomaGR February 15, 2023 15:57
blackgeorge-boom
blackgeorge-boom previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@blackgeorge-boom blackgeorge-boom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! I feel the comments have been addressed, so LGTM.

Curious about what @KomaGR also thinks.

KomaGR
KomaGR requested changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@KomaGR KomaGR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. I would like to ask you to please address the further comments I have made.

@PeiMu
fix commnets
7864342 
* Issue-637---improve-test-framework.
@PeiMu
Copy link
Collaborator Author

PeiMu commented Feb 16, 2023

Thank you for the changes. I would like to ask you to please address the further comments I have made.

Done. Can you check it again? Thanks.

@PeiMu
Copy link
Collaborator Author

PeiMu commented Feb 21, 2023

Just a reminder (mainly for myself), this PR won't be changed anymore. Bug fixes or new features will add in #643 or new issues.

@KomaGR KomaGR changed the base branch from master to issue-644 February 24, 2023 15:54
KomaGR
KomaGR requested changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@KomaGR KomaGR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you please make sure the code follows the coding conventions in https://github.com/phillipstanleymarbell/Noisy-lang-compiler/blob/master/README-CodingConventions.md ? Especially about if/else brackets and tabs.

@PeiMu PeiMu merged commit 543e0ee into issue-644 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomaGR KomaGR KomaGR requested changes

@blackgeorge-boom blackgeorge-boom blackgeorge-boom left review comments

Assignees

@PeiMu PeiMu

Labels
Prosecco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test framework
3 participants
@PeiMu @KomaGR @blackgeorge-boom