Repository navigation
fix: route extension requests to their worker, refuse messages once stopped - #2786
Open
nicolas-grekas wants to merge 1 commit into
Open
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
…topped SendRequest() resolved its worker by name, so an extension worker declared without one sent its requests to a regular thread; it now dispatches on the worker itself. SendMessage() after Shutdown() waited for a thread for good, it now returns ErrNotRunning as SendRequest() does. Both came up in the review of php#2617.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendRequest()looked its worker up by name, so an extension worker declared without one sent its requests to a regular thread. It now dispatches on the worker itself.SendMessage()afterShutdown()waited for a thread for good. It now returnsErrNotRunning, likeSendRequest().Both came up in the review of #2617, thanks @alexandre-daubois.