Support shouldNotReceive #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
should-not-receive
branch
from
6d8eb69 to
ab0dd99
Compare
This fixes the issue when using:
```
$this->fooMock->shouldNotReceive('doFoo')->andReturn('bar');
// Call to an undefined method Mockery\ExpectationInterface|Mockery\HigherOrderMessage::andReturn()
```
Add tests for `shouldHaveReceived` and `shouldNotHaveReceived`.
Fixes #11
ruudk
force-pushed
the
should-not-receive
branch
from
acfb5b0 to
2b1b760
Compare
|
@ondrejmirtes Do you think I should add all methods from https://github.com/mockery/mockery/blob/master/library/Mockery/LegacyMockInterface.php? Or is this enough? |
|
@ruudk I'm not sure, try to "break" this when LegacyMockInterface is involved, if you won't be able to, then I guess not :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue when using:
Fixes #11
Closes #9