Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of events in the Webhook API #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UsingSession
Copy link

@UsingSession UsingSession commented Jan 16, 2025

  1. Deprecation of events in the Webhook API:
  • The events attribute on webhook entities is considered deprecated and is replaced by enabled_events, starting January 1st 2025 events will be removed and will no longer be accepted.
  • POST requests :administration_id/webhooks now accept enabled_events instead of events.
  • GET requests :administration_id/webhooks/:id now return both events and enabled_events, until January 1st 2025.

@UsingSession UsingSession marked this pull request as ready for review January 16, 2025 12:27
@UsingSession
Copy link
Author

UsingSession commented Jan 16, 2025

I created patch. Replace events to enabled_events 308.patch

@UsingSession UsingSession changed the title Update Webhook.php Deprecation of events in the Webhook API Jan 16, 2025
@malle-pietje
Copy link
Contributor

That would mean that any calls to the API now fail when containing an events attribute, right? That is pretty impactful... I totally missed that change from Moneybird TBH.

When will this PR be merged into a formal release?

@UsingSession
Copy link
Author

@malle-pietje

That would mean that any calls to the API now fail when containing an events attribute, right?

It only happens when creating or recreating a webhook.

@malle-pietje
Copy link
Contributor

@malle-pietje

That would mean that any calls to the API now fail when containing an events attribute, right?

It only happens when creating or recreating a webhook.

Understood. We don't use that endpoint that frequently in our code but do need it when we add changes to the functionality at our end and need to create a new webhook set up in Moneybird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants