adjust api, test commands with a greenmail instance

config.sample.toml

@@ -7,7 +7,7 @@ display-name = "My example account"
 email = "example@localhost"
 
 sync = true
-sync-dir = "./.sync"
+sync-dir = "/tmp/himalaya-sync-example"
 
 # The default backend used for all the features like adding folders,
 # listing envelopes or copying messages.
@@ -21,7 +21,7 @@ imap.ssl = false
 imap.starttls = false
 imap.insecure = true
 imap.auth = "passwd"
-imap.passwd.raw = "example"
+imap.passwd.keyring = "example-passwd"
 
 # Override the backend used for sending messages.
 message.send.backend = "smtp"
@@ -35,3 +35,22 @@ smtp.starttls = false
 smtp.insecure = true
 smtp.auth = "passwd"
 smtp.passwd.raw = "example"
+
+[example-2]
+display-name = "My example account 2"
+email = "example2@localhost"
+
+backend = "imap"
+
+imap.host = "localhost"
+imap.port = 3143
+imap.login = "example2@localhost"
+imap.ssl = false
+imap.starttls = false
+imap.insecure = true
+imap.auth = "passwd"
+imap.passwd.raw = "example"
+
+message.send.backend = "sendmail"
+
+sendmail.cmd = "sendmail"

src/account/arg/name.rs

@@ -12,13 +12,13 @@ pub struct AccountNameArg {
 }
 
 /// The account name flag parser.
-#[derive(Debug, Parser)]
+#[derive(Debug, Default, Parser)]
 pub struct AccountNameFlag {
     /// Override the default account.
     ///
     /// An account name corresponds to an entry in the table at the
     /// root level of your TOML configuration file.
-    #[arg(long = "account", short = 'a', global = true)]
+    #[arg(long = "account", short = 'a')]
     #[arg(name = "account_name", value_name = "NAME")]
     pub name: Option<String>,
 }

src/account/command/mod.rs

@@ -15,7 +15,7 @@ use self::{
 ///
 /// An account is a set of settings, identified by an account
 /// name. Settings are directly taken from your TOML configuration
-/// file.
+/// file. This subcommand allows you to manage them.
 #[derive(Debug, Subcommand)]
 pub enum AccountSubcommand {
     #[command(alias = "cfg")]
@@ -24,7 +24,7 @@ pub enum AccountSubcommand {
     #[command(alias = "lst")]
     List(AccountListCommand),
 
-    #[command()]
+    #[command(alias = "synchronize", alias = "synchronise")]
     Sync(AccountSyncCommand),
 }
 

src/account/command/sync.rs

@@ -35,7 +35,7 @@ const SUB_PROGRESS_DONE_STYLE: Lazy<ProgressStyle> = Lazy::new(|| {
 /// Synchronize an account.
 ///
 /// This command allows you to synchronize all folders and emails
-/// (including envelopes and messages) of an account into a local
+/// (including envelopes and messages) of a given account into a local
 /// Maildir folder.
 #[derive(Debug, Parser)]
 pub struct AccountSyncCommand {

src/account/mod.rs

@@ -123,7 +123,10 @@ impl From<Iter<'_, String, TomlAccountConfig>> for Accounts {
                 Account::new(name, &backends, account.default.unwrap_or_default())
             })
             .collect();
-        accounts.sort_by(|a, b| b.name.partial_cmp(&a.name).unwrap());
+
+        // sort accounts by name
+        accounts.sort_by(|a, b| a.name.partial_cmp(&b.name).unwrap());
+
         Self(accounts)
     }
 }

src/cache/arg/disable.rs

@@ -1,7 +1,7 @@
 use clap::Parser;
 
 /// The disable cache flag parser.
-#[derive(Debug, Parser)]
+#[derive(Debug, Default, Parser)]
 pub struct CacheDisableFlag {
     /// Disable any sort of cache.
     ///

src/cli.rs

@@ -82,6 +82,7 @@ pub enum HimalayaCommand {
     Account(AccountSubcommand),
 
     #[command(subcommand)]
+    #[command(visible_alias = "mailbox", aliases = ["mailboxes", "mboxes", "mbox"])]
     #[command(alias = "folders")]
     Folder(FolderSubcommand),
 

src/email/envelope/flag/command/add.rs

@@ -8,7 +8,7 @@ use crate::{
     cache::arg::disable::CacheDisableFlag,
     config::TomlConfig,
     flag::arg::ids_and_flags::{into_tuple, IdsAndFlagsArgs},
-    folder::arg::name::FolderNameArg,
+    folder::arg::name::FolderNameOptionalFlag,
     printer::Printer,
 };
 
@@ -19,7 +19,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct FlagAddCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub args: IdsAndFlagsArgs,

src/email/envelope/flag/command/remove.rs

@@ -8,7 +8,7 @@ use crate::{
     cache::arg::disable::CacheDisableFlag,
     config::TomlConfig,
     flag::arg::ids_and_flags::{into_tuple, IdsAndFlagsArgs},
-    folder::arg::name::FolderNameArg,
+    folder::arg::name::FolderNameOptionalFlag,
     printer::Printer,
 };
 
@@ -19,7 +19,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct FlagRemoveCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub args: IdsAndFlagsArgs,

src/email/envelope/flag/command/set.rs

@@ -8,7 +8,7 @@ use crate::{
     cache::arg::disable::CacheDisableFlag,
     config::TomlConfig,
     flag::arg::ids_and_flags::{into_tuple, IdsAndFlagsArgs},
-    folder::arg::name::FolderNameArg,
+    folder::arg::name::FolderNameOptionalFlag,
     printer::Printer,
 };
 
@@ -19,7 +19,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct FlagSetCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub args: IdsAndFlagsArgs,

src/email/message/arg/body.rs

@@ -6,7 +6,7 @@ use std::ops::Deref;
 pub struct MessageRawBodyArg {
     /// Prefill the template with a custom body.
     #[arg(trailing_var_arg = true)]
-    #[arg(name = "body-raw")]
+    #[arg(name = "body_raw", value_name = "BODY")]
     pub raw: Vec<String>,
 }
 

src/email/message/arg/mod.rs

@@ -1,3 +1,20 @@
+use clap::Parser;
+
 pub mod body;
 pub mod header;
 pub mod reply;
+
+/// The raw message argument parser.
+#[derive(Debug, Parser)]
+pub struct MessageRawArg {
+    /// The raw message, including headers and body.
+    #[arg(trailing_var_arg = true)]
+    #[arg(name = "message_raw", value_name = "MESSAGE")]
+    pub raw: Vec<String>,
+}
+
+impl MessageRawArg {
+    pub fn raw(self) -> String {
+        self.raw.join(" ").replace("\r", "").replace("\n", "\r\n")
+    }
+}

src/email/message/attachment/command/download.rs

@@ -6,8 +6,8 @@ use uuid::Uuid;
 
 use crate::{
     account::arg::name::AccountNameFlag, backend::Backend, cache::arg::disable::CacheDisableFlag,
-    config::TomlConfig, envelope::arg::ids::EnvelopeIdsArgs, folder::arg::name::FolderNameArg,
-    printer::Printer,
+    config::TomlConfig, envelope::arg::ids::EnvelopeIdsArgs,
+    folder::arg::name::FolderNameOptionalFlag, printer::Printer,
 };
 
 /// Download all attachments for the given message.
@@ -17,7 +17,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct AttachmentDownloadCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub envelopes: EnvelopeIdsArgs,

src/email/message/command/delete.rs

@@ -4,8 +4,8 @@ use log::info;
 
 use crate::{
     account::arg::name::AccountNameFlag, backend::Backend, cache::arg::disable::CacheDisableFlag,
-    config::TomlConfig, envelope::arg::ids::EnvelopeIdsArgs, folder::arg::name::FolderNameArg,
-    printer::Printer,
+    config::TomlConfig, envelope::arg::ids::EnvelopeIdsArgs,
+    folder::arg::name::FolderNameOptionalFlag, printer::Printer,
 };
 
 /// Mark as deleted a message from a folder.
@@ -17,7 +17,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct MessageDeleteCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub envelopes: EnvelopeIdsArgs,

src/email/message/command/forward.rs

@@ -1,16 +1,14 @@
 use anyhow::{anyhow, Result};
-use atty::Stream;
 use clap::Parser;
 use log::info;
-use std::io::{self, BufRead};
 
 use crate::{
     account::arg::name::AccountNameFlag,
     backend::Backend,
     cache::arg::disable::CacheDisableFlag,
     config::TomlConfig,
     envelope::arg::ids::EnvelopeIdArg,
-    folder::arg::name::FolderNameArg,
+    folder::arg::name::FolderNameOptionalFlag,
     message::arg::{body::MessageRawBodyArg, header::HeaderRawArgs},
     printer::Printer,
     ui::editor,
@@ -25,7 +23,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct MessageForwardCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub envelope: EnvelopeIdArg,
@@ -55,19 +53,6 @@ impl MessageForwardCommand {
             config.clone().into_account_configs(account, cache)?;
         let backend = Backend::new(toml_account_config, account_config.clone(), true).await?;
 
-        let is_tty = atty::is(Stream::Stdin);
-        let is_json = printer.is_json();
-        let body = if !self.body.is_empty() && (is_tty || is_json) {
-            self.body.raw()
-        } else {
-            io::stdin()
-                .lock()
-                .lines()
-                .filter_map(Result::ok)
-                .collect::<Vec<String>>()
-                .join("\r\n")
-        };
-
         let id = self.envelope.id;
         let tpl = backend
             .get_messages(folder, &[id])
@@ -76,7 +61,7 @@ impl MessageForwardCommand {
             .ok_or(anyhow!("cannot find message"))?
             .to_forward_tpl_builder(&account_config)
             .with_headers(self.headers.raw)
-            .with_body(body)
+            .with_body(self.body.raw())
             .build()
             .await?;
         editor::edit_tpl_with_editor(&account_config, printer, &backend, tpl).await

src/email/message/command/mailto.rs

@@ -4,7 +4,10 @@ use log::{debug, info};
 use mail_builder::MessageBuilder;
 use url::Url;
 
-use crate::{backend::Backend, config::TomlConfig, printer::Printer, ui::editor};
+use crate::{
+    account::arg::name::AccountNameFlag, backend::Backend, cache::arg::disable::CacheDisableFlag,
+    config::TomlConfig, printer::Printer, ui::editor,
+};
 
 /// Parse and edit a message from a mailto URL string.
 ///
@@ -17,19 +20,31 @@ pub struct MessageMailtoCommand {
     /// The mailto url.
     #[arg()]
     pub url: Url,
+
+    #[command(flatten)]
+    pub cache: CacheDisableFlag,
+
+    #[command(flatten)]
+    pub account: AccountNameFlag,
 }
 
 impl MessageMailtoCommand {
     pub fn new(url: &str) -> Result<Self> {
-        let url = Url::parse(url)?;
-        Ok(Self { url })
+        Ok(Self {
+            url: Url::parse(url)?,
+            cache: Default::default(),
+            account: Default::default(),
+        })
     }
 
     pub async fn execute(self, printer: &mut impl Printer, config: &TomlConfig) -> Result<()> {
         info!("executing message mailto command");
 
+        let account = self.account.name.as_ref().map(String::as_str);
+        let cache = self.cache.disable;
+
         let (toml_account_config, account_config) =
-            config.clone().into_account_configs(None, false)?;
+            config.clone().into_account_configs(account, cache)?;
         let backend = Backend::new(toml_account_config, account_config.clone(), true).await?;
 
         let mut builder = MessageBuilder::new().to(self.url.path());

src/email/message/command/mod.rs

@@ -32,32 +32,34 @@ pub enum MessageSubcommand {
     #[command(arg_required_else_help = true)]
     Read(MessageReadCommand),
 
-    #[command(alias = "add", alias = "create", alias = "new", alias = "compose")]
+    #[command(aliases = ["add", "create", "new", "compose"])]
     Write(MessageWriteCommand),
 
     #[command()]
     Reply(MessageReplyCommand),
 
-    #[command(alias = "fwd")]
+    #[command(aliases = ["fwd", "fd"])]
     Forward(MessageForwardCommand),
 
     #[command()]
     Mailto(MessageMailtoCommand),
 
     #[command(arg_required_else_help = true)]
-    #[command(alias = "add", alias = "create")]
     Save(MessageSaveCommand),
 
     #[command(arg_required_else_help = true)]
     Send(MessageSendCommand),
 
     #[command(arg_required_else_help = true)]
+    #[command(aliases = ["cpy", "cp"])]
     Copy(MessageCopyCommand),
 
     #[command(arg_required_else_help = true)]
+    #[command(alias = "mv")]
     Move(MessageMoveCommand),
 
     #[command(arg_required_else_help = true)]
+    #[command(aliases = ["remove", "rm"])]
     Delete(MessageDeleteCommand),
 }
 

src/email/message/command/read.rs

@@ -5,8 +5,8 @@ use mml::message::FilterParts;
 
 use crate::{
     account::arg::name::AccountNameFlag, backend::Backend, cache::arg::disable::CacheDisableFlag,
-    config::TomlConfig, envelope::arg::ids::EnvelopeIdsArgs, folder::arg::name::FolderNameArg,
-    printer::Printer,
+    config::TomlConfig, envelope::arg::ids::EnvelopeIdsArgs,
+    folder::arg::name::FolderNameOptionalFlag, printer::Printer,
 };
 
 /// Read a message.
@@ -15,7 +15,7 @@ use crate::{
 #[derive(Debug, Parser)]
 pub struct MessageReadCommand {
     #[command(flatten)]
-    pub folder: FolderNameArg,
+    pub folder: FolderNameOptionalFlag,
 
     #[command(flatten)]
     pub envelopes: EnvelopeIdsArgs,