This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
ignore context deadline exceeded error for bank2 admin check table #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <[email protected]>
cosven
approved these changes
Mar 29, 2021
zyguan
reviewed
Apr 2, 2021
| @@ -330,7 +330,8 @@ func (c *bank2Client) verify(db *sql.DB) { | |||
| if strings.Contains(errStr, "1105") && | |||
| !(strings.Contains(errStr, "cancelled DDL job") || | |||
| strings.Contains(errStr, "Information schema is changed") || | |||
| strings.Contains(errStr, "TiKV server timeout")) { | |||
| strings.Contains(errStr, "TiKV server timeout") || | |||
| strings.Contains(errStr, "context deadline exceeded")) { | |||
There was a problem hiding this comment.
I also add "injected" to the whitelist for testing with failpoints.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yilin Chen [email protected]
What problem does this PR solve?
Closes #384 again :(
What is changed and how does it work?
I don't have a good idea about solving the problem.
ADMIN CHECK TABLEhas various error patterns and is hard to match as well. So, still, I add "context deadline exceeded" to the filter list.Does this PR introduce a user-facing change?: