Release 1.1.0 (#16)

* bump version * Update rules.json * CLOUD-571 - Missed a couple of addErrors --------- Co-authored-by: GitHub Action <[email protected]>
pingidentity · Dec 5, 2024 · 8b96cd9 · 8b96cd9
1 parent 1898501
commit 8b96cd9
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/docs/rules.json b/docs/rules.json
@@ -2,7 +2,7 @@
   {
     "name": "@ping-identity/dvlint-base-rule-pack",
     "description": "Collection of base rules used to lint DaVinci flows.",
-    "version": "1.0.9",
+    "version": "1.1.0",
     "rules": [
       {
         "id": "dv-rule-annotations-001",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ping-identity/dvlint-base-rule-pack",
-  "version": "1.0.9",
+  "version": "1.1.0",
   "description": "Collection of base rules used to lint DaVinci flows.",
   "main": "RulePack.js",
   "scripts": {

diff --git a/rules/dv-rule-node-002/DisabledNodeRule.js b/rules/dv-rule-node-002/DisabledNodeRule.js
@@ -32,6 +32,7 @@ class DisabledNodeRule extends LintRule {
 
           if (data.isDisabled === true) {
             this.addError("dv-er-node-001", {
+              flowId: flow.flowId,
               messageArgs: [`(${data.id})`],
               recommendationArgs: [`(${data.id})`],
               nodeId: data.id,
@@ -41,6 +42,7 @@ class DisabledNodeRule extends LintRule {
           if (data.status === 'unconfigured') {
             const connectorInstanceName = data.name.toLowerCase().includes('connector') ? data.name : data.name + ' connector';
             this.addError("dv-er-node-002", {
+              flowId: flow.flowId,
               recommendationArgs: [`${connectorInstanceName}`],
               nodeId: data.id,
             });

diff --git a/rules/dv-rule-pingOneFlow-001/PingOneFlowRule.js b/rules/dv-rule-pingOneFlow-001/PingOneFlowRule.js
@@ -22,7 +22,7 @@ class PingOneFlowRule extends LintRule {
 
       // Incorrect ending nodes for PingOne flow
       if (targetFlow?.settings?.pingOneFlow) {
-        const endNodesCapability = ['returnSuccessResponseRedirect', 'returnErrorResponseRedirect'];        
+        const endNodesCapability = ['returnSuccessResponseRedirect', 'returnErrorResponseRedirect'];
         const endNodesData = targetFlow.graphData.elements.nodes?.filter(node => endNodesCapability.includes(node.data.capabilityName)) || [];
         const nodeIdMap = endNodesData.map(node => node.data.id);
         const nodeSourceMap = targetFlow.graphData.elements.edges?.map(edge => edge.data.source) || [];
@@ -34,6 +34,7 @@ class PingOneFlowRule extends LintRule {
         });
         if (!validEndNode) {
           this.addError("dv-er-pingOneFlow-001", {
+            flowId: targetFlow.flowId,
             messageArgs: [targetFlow.name],
           });
         }