Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify client extension for working with not-quite-compliant servers #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

simplify client extension for working with not-quite-compliant servers #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scim2-sdk-client/src/main/java/com/unboundid/scim2/client/requests/CreateRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
/**
* A builder for SCIM create requests.
*/
public final class CreateRequestBuilder<T extends ScimResource>
public class CreateRequestBuilder<T extends ScimResource>
extends ResourceReturningRequestBuilder<CreateRequestBuilder<T>>
{
private final T resource;
Expand Down
2 changes: 1 addition & 1 deletion scim2-sdk-client/src/main/java/com/unboundid/scim2/client/requests/DeleteRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public DeleteRequestBuilder ifMatch(final String version)
* {@inheritDoc}
*/
@Override
Invocation.Builder buildRequest()
protected Invocation.Builder buildRequest()
{
Invocation.Builder request = super.buildRequest();
if(version != null)
Expand Down
2 changes: 1 addition & 1 deletion scim2-sdk-client/src/main/java/com/unboundid/scim2/client/requests/ModifyRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private ModifyRequestBuilder(final WebTarget target)
* {@inheritDoc}
*/
@Override
Invocation.Builder buildRequest()
protected Invocation.Builder buildRequest()
{
Invocation.Builder request = super.buildRequest();
if(version != null)
Expand Down
4 changes: 2 additions & 2 deletions ...2-sdk-client/src/main/java/com/unboundid/scim2/client/requests/ReplaceRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/**
* A builder for SCIM replace requests.
*/
public final class ReplaceRequestBuilder<T extends ScimResource>
public class ReplaceRequestBuilder<T extends ScimResource>
extends ResourceReturningRequestBuilder<ReplaceRequestBuilder<T>>
{
private final T resource;
Expand Down Expand Up @@ -63,7 +63,7 @@ public ReplaceRequestBuilder<T> ifMatch()
* {@inheritDoc}
*/
@Override
Invocation.Builder buildRequest()
protected Invocation.Builder buildRequest()
{
Invocation.Builder request = super.buildRequest();
if(version != null)
Expand Down
6 changes: 3 additions & 3 deletions scim2-sdk-client/src/main/java/com/unboundid/scim2/client/requests/RequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ static String getResourceVersion(final ScimResource resource)
* @param response The JAX-RS response.
* @return the converted ScimException.
*/
static ScimException toScimException(final Response response)
protected static ScimException toScimException(final Response response)
{
try
{
Expand Down Expand Up @@ -203,7 +203,7 @@ protected WebTarget target()
*
* @return The WebTarget for the request.
*/
WebTarget buildTarget()
protected WebTarget buildTarget()
{
for(Map.Entry<String, List<Object>> queryParam : queryParams.entrySet())
{
Expand Down Expand Up @@ -237,7 +237,7 @@ protected List<String> getAccept()
*
* @return The Invocation.Builder for the request.
*/
Invocation.Builder buildRequest()
protected Invocation.Builder buildRequest()
{
Invocation.Builder builder =
buildTarget().request(accept.toArray(new String[accept.size()]));
Expand Down
2 changes: 1 addition & 1 deletion ...nt/src/main/java/com/unboundid/scim2/client/requests/ResourceReturningRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public abstract class ResourceReturningRequestBuilder
*
* @return The WebTarget for the request.
*/
WebTarget buildTarget()
protected WebTarget buildTarget()
{
if(attributes != null && attributes.size() > 0)
{
Expand Down
2 changes: 1 addition & 1 deletion ...-sdk-client/src/main/java/com/unboundid/scim2/client/requests/RetrieveRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private RetrieveRequestBuilder(final WebTarget target)
* {@inheritDoc}
*/
@Override
Invocation.Builder buildRequest()
protected Invocation.Builder buildRequest()
{
Invocation.Builder request = super.buildRequest();
if(version != null)
Expand Down
4 changes: 2 additions & 2 deletions scim2-sdk-client/src/main/java/com/unboundid/scim2/client/requests/SearchRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
/**
* A builder for SCIM search requests.
*/
public final class SearchRequestBuilder
public class SearchRequestBuilder
extends ResourceReturningRequestBuilder<SearchRequestBuilder>
{
private String filter;
Expand Down Expand Up @@ -119,7 +119,7 @@ public SearchRequestBuilder page(final int startIndex,
* {@inheritDoc}
*/
@Override
WebTarget buildTarget()
protected WebTarget buildTarget()
{
WebTarget target = super.buildTarget();
if(filter != null)
Expand Down