Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci, More linter #116

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Upgrade golangci, More linter #116

merged 1 commit into from
Jan 9, 2025

Conversation

joeturki
Copy link
Member

@joeturki joeturki commented Jan 8, 2025

Description

Upgrade golangci version, Introduce more linters.

Reference issue

pion/.goassets#220

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.71%. Comparing base (b6abcca) to head (eba0ffe).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
logger.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   55.46%   55.71%   +0.25%     
==========================================
  Files           2        2              
  Lines         119      140      +21     
==========================================
+ Hits           66       78      +12     
- Misses         51       60       +9     
  Partials        2        2              
Flag Coverage Δ
go 55.71% <88.88%> (+0.25%) ⬆️
wasm 55.71% <88.88%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeturki joeturki mentioned this pull request Jan 8, 2025
19 tasks
Copy link
Member

@Sean-Der Sean-Der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this is a huge deal to me @joeturki

pion is starting to feel unloved, this makes a big difference

@Sean-Der Sean-Der merged commit 8466bde into master Jan 9, 2025
13 checks passed
@Sean-Der Sean-Der deleted the fix/lint branch January 9, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants