Skip to content

Add e2e tests for GET /login/oauth/authorize - #6713

Closed
apata wants to merge 2 commits into
mcp/oauth-controllersfrom
mcp/oauth-controllers-with-e2e-tests
Closed

apata wants to merge 2 commits into
mcp/oauth-controllersfrom
mcp/oauth-controllers-with-e2e-tests

Conversation

@apata

@apata apata commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Adds e2e test suite for authorize screen. Depends on #6711.

E2e tests are appropriate because this tests the full flow with JS and everything.

Our mocking options aren't ideal. Ideas welcome.

In this variant,

  • we swap out DNS lookup implementation for a fake one for the app under test. This affects all e2e tests theoretically.
  • for OAuth CIMD fetcher, we swap out real Req for a fake one that responds with a mock identity metadata document

@apata apata changed the title Add e2e tests for authorize screen Add e2e tests for GET /login/oauth/authorize Sep 24, 2026
@apata
apata requested a review from a team September 30, 2026 06:18
@apata
apata force-pushed the mcp/oauth-controllers-with-e2e-tests branch from f45c92a to 3e11b0a Compare September 30, 2026 08:22
@apata apata closed this Oct 5, 2026
@apata
apata deleted the mcp/oauth-controllers-with-e2e-tests branch October 5, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant