Repository navigation
Extract the filter menu submenu into a shared component - #6716
Merged
Merged
Conversation
sanne-san
force-pushed
the
sanne-filter-submenu
branch
from
September 25, 2026 14:09
2cee781 to
3c446a9
Compare
sanne-san
force-pushed
the
sanne-filter-submenu
branch
from
September 29, 2026 11:39
3c446a9 to
73d2c0a
Compare
sanne-san
marked this pull request as ready for review
October 1, 2026 13:33
- Move the submenu logic from `filter-menu.tsx` into a new `submenu.tsx`: the open and close state, the delay on hover, and the position. On wide screens the submenu opens beside the menu. On small screens it replaces the menu. - No functionality change, and only the filter menu uses the new component for now. In a follow-up PR, the submenu will also be used on the segment pill in the top nav.
zoldar
force-pushed
the
sanne-filter-submenu
branch
from
October 7, 2026 09:00
73d2c0a to
5864348
Compare
|
zoldar
approved these changes
Oct 7, 2026
tsubery
pushed a commit
to tsubery/analytics
that referenced
this pull request
Oct 21, 2026
* Extract the filter menu submenu into a shared component - Move the submenu logic from `filter-menu.tsx` into a new `submenu.tsx`: the open and close state, the delay on hover, and the position. On wide screens the submenu opens beside the menu. On small screens it replaces the menu. - No functionality change, and only the filter menu uses the new component for now. In a follow-up PR, the submenu will also be used on the segment pill in the top nav. * Remove mouseleave trigger after rebase * Apply formatting --------- Co-authored-by: Adrian Gruntkowski <adrian.gruntkowski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
filter-menu.tsxinto a newsubmenu.tsx: the open and close state, the delay on hover, and the position. On wide screens the submenu opens beside the menu. On small screens it replaces the menu.Tests
Changelog
Documentation
Dark mode