Skip to content

fix(pat-contentbrowser): scroll to the upload form after rendering - #1671

Open
MrTango wants to merge 1 commit into
masterfrom
pr/contentbrowser-upload-scroll
Open

MrTango wants to merge 1 commit into
masterfrom
pr/contentbrowser-upload-scroll

Conversation

@MrTango

@MrTango MrTango commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Scroll to the upload form after it is rendered, so it is included in the browser's scroll width.

 upload
-  scroll right → show form
+  show form → wait for render → scroll right

Evidence

  • Before (code path): Scrolling runs before the upload form exists.
    After: A regression test asserts that the form exists when the final scroll occurs.
  • pnpm test --runInBand: 60 suites passed; 513 tests passed, 15 skipped.
  • pnpm build:webpack: passed with size/performance warnings.

Merge Danger

Door: two-way

Blast Radius: scrolling

Changes content-browser upload scroll timing. The upload-replace branch adds the same test filename; combine both sets of tests when merging.

Assisted-by: GPT 6.1 Sol

upload() scrolled to the right before the upload column existed, so in
deep folders the column stayed clipped past the window edge.
@MrTango
MrTango marked this pull request as ready for review November 13, 2026 08:08
@MrTango
MrTango requested a review from petschki November 13, 2026 08:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant