Depracated action tracking #1160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2024 17:04
I think this regtest was maybe migrated across from version 2.9. It can't pass if you run it in plumed 2.10 unless you make these changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // This is used for noting actions that have been deprecated | ||
| std::string replacement = keys.getReplacementAction(); | ||
| if( replacement!="none" ) { | ||
| bool found=false; |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a facility where you can note that an action should no longer be used by adding the command:
In the
registerKeywordsmethod of an action. The deprecated actions are then tracked in the syntax.json file. By putting this information in that file this way we can note eggs and lessons that are using actions that we have moved on from at some stage in the future.The first commit in this sequence fixes a regtest that appears to be broken on master. I am not sure where this regtest came from.
Target release
I would like my code to appear in release 2.11
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests