-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gameplay permissions #5544
Draft
dktapps
wants to merge
18
commits into
minor-next
Choose a base branch
from
gameplay-permissions
base: minor-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Gameplay permissions #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
added
Category: Core
Related to internal functionality
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Category: UI
Related to the user interface (e.g. commands, terminal output)
labels
Jan 30, 2023
dktapps
added
the
Status: Blocked
Depends on other changes which are yet to be completed
label
Nov 14, 2024
Blocking items:
|
the remaining bool flags are user input toggles, not abilities, so it doesn't make sense to move them to permissions. permissions are intended for what the player is *allowed* to do, not what they *want* to do.
this eliminates all remaining usages of isCreative(), except for reach distance checks. Reach distance can't be migrated to a permission in an obvious way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Core
Related to internal functionality
Category: UI
Related to the user interface (e.g. commands, terminal output)
Status: Blocked
Depends on other changes which are yet to be completed
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR implements #5512.
The motivation for this PR is described in #5512.
Relevant issues
Closes #5512
Changes
API changes
Behavioural changes
CanPlaceOn
andCanDestroy
checkstrue
on the player.Backwards compatibility
Should be fully backwards compatible.
Follow-up
Add further permissions for the following:
Tests
This has been tested in-game.