Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: New icon picker field #4782

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Feature: New icon picker field #4782

wants to merge 14 commits into from

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Mar 5, 2018 •
edited
Loading

Issue: #4298

It will add a composer dependency for WP Icon Picker library:
https://github.com/ineagu/wp-icon-picker

TODO:

  • Selection of which icon libraries are available for a field
    • Implement this globally or per-field?
  • Other field options?
  • field::display() implementation
  • field::ui() implementation
  • Test with front-end forms
  • Other tests?
  • Check storage (@sc0ttkclark) Currently stores as an array ( array( 'type' => '', 'icon' => '' ) )

@JoryHogeveen JoryHogeveen added the Type: Feature Features that add entirely new functionality that was not there before label Mar 5, 2018
@JoryHogeveen JoryHogeveen self-assigned this Mar 5, 2018
@JoryHogeveen JoryHogeveen requested a review from pglewis as a code owner March 5, 2018 14:03
@ghost ghost added the Status: In Progress Issue or PR is currently in progress but not yet done label Mar 5, 2018
@ghost ghost assigned sc0ttkclark Mar 6, 2018
@sc0ttkclark
Copy link
Member

Why store type and icon? Why not just store the type and get the associated type with the icon selected?

@JoryHogeveen
Copy link
Member Author

JoryHogeveen commented Mar 6, 2018 •
edited
Loading

That is how wp-icon-picker handles it.

type is the font library prefix (fa, dashicons, etc) and icon is the actual icon class.
In case of an SVG image the type => 'svg' and icon is the attachment ID.

sc0ttkclark
sc0ttkclark previously approved these changes Mar 22, 2018
View reviewed changes
@sc0ttkclark
Copy link
Member

Can we store formatted separated by pipe "|"?

Like "dashicons|the-icon"

@sc0ttkclark sc0ttkclark added this to the Pods 2.8 milestone Mar 22, 2018
@JoryHogeveen
Copy link
Member Author

I don't see why not. A space would work even better I guess.

@sc0ttkclark sc0ttkclark marked this pull request as draft July 15, 2020 16:20
@sc0ttkclark sc0ttkclark changed the base branch from 2.x to main July 15, 2020 16:20
@sc0ttkclark sc0ttkclark dismissed their stale review July 15, 2020 16:20

The base branch was changed.

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8, Pods 2.9, Pods 3.0 Aug 17, 2021
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.0, Backlog Apr 25, 2023
@vgstef
Copy link

vgstef commented Jun 28, 2023

Is there any developement or a roadmap to add this icon picker in Pods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@zrothauser zrothauser

Labels
Keyword: Puntable Status: In Progress Issue or PR is currently in progress but not yet done Type: Feature Features that add entirely new functionality that was not there before
Projects
React Work
Status: 📋 Backlog
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@JoryHogeveen @sc0ttkclark @vgstef @zrothauser